Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 267363003: Revert of Expose events in workers as per latest DOM specification (Closed)

Created:
6 years, 7 months ago by Inactive
Modified:
6 years, 7 months ago
CC:
blink-reviews, arv+blink, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Revert of Expose events in workers as per latest DOM specification (https://codereview.chromium.org/262173006/) Reason for revert: This may be causing issues with thread safety. I am reverting until I get a chance to investigate. Original issue's description: > Expose events in workers as per latest DOM specification > > Expose events in workers as per latest DOM specification: > https://github.com/whatwg/dom/commit/0f69e7175dcae9edffa636bb213991330d225bf3 > > This CL exposes Event, CustomEvent and EventTarget to Workers and not only > in the primary global scope (Window), as per the latest DOM specification. > > Firefox 29 exposes both Event and EventTarget to workers but not CustomEvent > (known bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1003432). > IE11 exposes Event only to workers. > > R=arv@chromium.org, tkent@chromium.org > BUG=370011 > TEST=webexposed/global-constructors-listing-dedicated-worker.html > TEST=webexposed/global-constructors-listing-shared-worker.html > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173328 TBR=arv@chromium.org,tkent@chromium.org,eseidel@chromium.org NOTREECHECKS=true NOTRY=true BUG=370011 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-dedicated-worker-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-shared-worker-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-dedicated-worker-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-shared-worker-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/events/CustomEvent.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/Event.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/EventTarget.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
Created Revert of Expose events in workers as per latest DOM specification
6 years, 7 months ago (2014-05-07 13:37:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/267363003/1
6 years, 7 months ago (2014-05-07 13:39:04 UTC) #2
commit-bot: I haz the power
Change committed as 173525
6 years, 7 months ago (2014-05-07 13:39:38 UTC) #3
tkent
6 years, 7 months ago (2014-05-07 23:28:00 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698