Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/hydrogen-instructions.h

Issue 267363002: Fix invalid ASSERT() in HasStableMapValue(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_HYDROGEN_INSTRUCTIONS_H_ 5 #ifndef V8_HYDROGEN_INSTRUCTIONS_H_
6 #define V8_HYDROGEN_INSTRUCTIONS_H_ 6 #define V8_HYDROGEN_INSTRUCTIONS_H_
7 7
8 #include "v8.h" 8 #include "v8.h"
9 9
10 #include "allocation.h" 10 #include "allocation.h"
(...skipping 3599 matching lines...) Expand 10 before | Expand all | Expand 10 after
3610 bool BooleanValue() const { return boolean_value_; } 3610 bool BooleanValue() const { return boolean_value_; }
3611 bool IsUndetectable() const { return is_undetectable_; } 3611 bool IsUndetectable() const { return is_undetectable_; }
3612 InstanceType GetInstanceType() const { return instance_type_; } 3612 InstanceType GetInstanceType() const { return instance_type_; }
3613 3613
3614 bool HasMapValue() const { return instance_type_ == MAP_TYPE; } 3614 bool HasMapValue() const { return instance_type_ == MAP_TYPE; }
3615 Unique<Map> MapValue() const { 3615 Unique<Map> MapValue() const {
3616 ASSERT(HasMapValue()); 3616 ASSERT(HasMapValue());
3617 return Unique<Map>::cast(GetUnique()); 3617 return Unique<Map>::cast(GetUnique());
3618 } 3618 }
3619 bool HasStableMapValue() const { 3619 bool HasStableMapValue() const {
3620 ASSERT(HasMapValue()); 3620 ASSERT(HasMapValue() || !has_stable_map_value_);
3621 return has_stable_map_value_; 3621 return has_stable_map_value_;
3622 } 3622 }
3623 3623
3624 bool HasObjectMap() const { return !object_map_.IsNull(); } 3624 bool HasObjectMap() const { return !object_map_.IsNull(); }
3625 Unique<Map> ObjectMap() const { 3625 Unique<Map> ObjectMap() const {
3626 ASSERT(HasObjectMap()); 3626 ASSERT(HasObjectMap());
3627 return object_map_; 3627 return object_map_;
3628 } 3628 }
3629 3629
3630 virtual intptr_t Hashcode() V8_OVERRIDE { 3630 virtual intptr_t Hashcode() V8_OVERRIDE {
(...skipping 4001 matching lines...) Expand 10 before | Expand all | Expand 10 after
7632 virtual bool IsDeletable() const V8_OVERRIDE { return true; } 7632 virtual bool IsDeletable() const V8_OVERRIDE { return true; }
7633 }; 7633 };
7634 7634
7635 7635
7636 #undef DECLARE_INSTRUCTION 7636 #undef DECLARE_INSTRUCTION
7637 #undef DECLARE_CONCRETE_INSTRUCTION 7637 #undef DECLARE_CONCRETE_INSTRUCTION
7638 7638
7639 } } // namespace v8::internal 7639 } } // namespace v8::internal
7640 7640
7641 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 7641 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698