ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h - Issue 2673553003: [ObjC ARC] Converts ios/chrome/browser/ui/history:eg_tests to ARC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h

Issue 2673553003: [ObjC ARC] Converts ios/chrome/browser/ui/history:eg_tests to ARC. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/history/tab_history_popup_controller_egtest.mm ('k') | ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h

diff --git a/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h b/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h

index c3e52c47f30cdc8989e9edcd12b8ae4452470745..b378fd985a652458456a5408cb6431dad79cc203 100644

--- a/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h

+++ b/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h

@@ -52,7 +52,8 @@ class FakeChromeIdentityService : public ChromeIdentityService {

MOCK_METHOD2(GetAvatarForIdentity,

void(ChromeIdentity* identity, GetAvatarCallback callback));

- MOCK_METHOD1(GetCachedAvatarForIdentity, UIImage*(ChromeIdentity* identity));

+ virtual UIImage* GetCachedAvatarForIdentity(

marq (ping after 24h) 2017/02/03 14:26:14 Add a comment explaining why this can't be mocked

stkhapugin 2017/02/03 15:49:07 I actually made a separate CL where I've addressed

+ ChromeIdentity* identity) override;

MOCK_METHOD2(GetHostedDomainForIdentity,

void(ChromeIdentity* identity,