Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2673533002: Moved overflow-x and overflow-y to be generated in ComputedStyleBase. (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h
index 88dd1e295373d6973753301a4e4af167bc12d840..9414d4f58eabd609721a4798aded33d53864385d 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -222,8 +222,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
bool operator==(const NonInheritedData& other) const {
return m_effectiveDisplay == other.m_effectiveDisplay &&
m_originalDisplay == other.m_originalDisplay &&
- m_overflowX == other.m_overflowX &&
- m_overflowY == other.m_overflowY &&
m_verticalAlign == other.m_verticalAlign &&
m_position == other.m_position &&
m_tableLayout == other.m_tableLayout &&
@@ -250,8 +248,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
unsigned m_effectiveDisplay : 5; // EDisplay
unsigned m_originalDisplay : 5; // EDisplay
- unsigned m_overflowX : 3; // EOverflow
- unsigned m_overflowY : 3; // EOverflow
unsigned m_verticalAlign : 4; // EVerticalAlign
unsigned m_position : 3; // EPosition
unsigned m_tableLayout : 1; // ETableLayout
@@ -304,8 +300,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
m_nonInheritedData.m_effectiveDisplay =
m_nonInheritedData.m_originalDisplay =
static_cast<unsigned>(initialDisplay());
- m_nonInheritedData.m_overflowX = static_cast<unsigned>(initialOverflowX());
- m_nonInheritedData.m_overflowY = static_cast<unsigned>(initialOverflowY());
m_nonInheritedData.m_verticalAlign =
static_cast<unsigned>(initialVerticalAlign());
m_nonInheritedData.m_position = initialPosition();
@@ -1464,24 +1458,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
SET_VAR(m_rareNonInheritedData, m_outline.m_offset, v);
}
- // overflow-x
- static EOverflow initialOverflowX() { return EOverflow::kVisible; }
- EOverflow overflowX() const {
- return static_cast<EOverflow>(m_nonInheritedData.m_overflowX);
- }
- void setOverflowX(EOverflow v) {
- m_nonInheritedData.m_overflowX = static_cast<unsigned>(v);
- }
-
- // overflow-y
- static EOverflow initialOverflowY() { return EOverflow::kVisible; }
- EOverflow overflowY() const {
- return static_cast<EOverflow>(m_nonInheritedData.m_overflowY);
- }
- void setOverflowY(EOverflow v) {
- m_nonInheritedData.m_overflowY = static_cast<unsigned>(v);
- }
-
// Padding properties.
static Length initialPadding() { return Length(Fixed); }

Powered by Google App Engine
This is Rietveld 408576698