Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2673533002: Moved overflow-x and overflow-y to be generated in ComputedStyleBase. (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index deca619c92323d67c5a079fac53e1d3860d8f849..b4f9aefc1e6f8baecbfd1560b199d1390e57aadd 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -367,8 +367,6 @@ void ComputedStyle::copyNonInheritedFromCached(const ComputedStyle& other) {
other.m_nonInheritedData.m_effectiveDisplay;
m_nonInheritedData.m_originalDisplay =
other.m_nonInheritedData.m_originalDisplay;
- m_nonInheritedData.m_overflowX = other.m_nonInheritedData.m_overflowX;
- m_nonInheritedData.m_overflowY = other.m_nonInheritedData.m_overflowY;
m_nonInheritedData.m_verticalAlign = other.m_nonInheritedData.m_verticalAlign;
m_nonInheritedData.m_position = other.m_nonInheritedData.m_position;
m_nonInheritedData.m_tableLayout = other.m_nonInheritedData.m_tableLayout;
@@ -812,8 +810,7 @@ bool ComputedStyle::diffNeedsFullLayoutAndPaintInvalidation(
getWritingMode() != other.getWritingMode())
return true;
- if (m_nonInheritedData.m_overflowX != other.m_nonInheritedData.m_overflowX ||
- m_nonInheritedData.m_overflowY != other.m_nonInheritedData.m_overflowY ||
+ if (overflowX() != other.overflowX() || overflowY() != other.overflowY() ||
clear() != other.clear() || getUnicodeBidi() != other.getUnicodeBidi() ||
floating() != other.floating() ||
m_nonInheritedData.m_originalDisplay !=

Powered by Google App Engine
This is Rietveld 408576698