Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6732)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.h

Issue 2673503002: Slightly simplify location bar bg/border painting. (Closed)
Patch Set: no functional change Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_bar_view.h
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.h b/chrome/browser/ui/views/location_bar/location_bar_view.h
index 1d9b7a4753254a4db0faf39c4626446364eb032b..235701bb2935d1e0d6d1b5460b4b500d9cb24c55 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.h
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.h
@@ -127,9 +127,9 @@ class LocationBarView : public LocationBar,
~LocationBarView() override;
- // Returns the color for the location bar border given the window's
- // |incognito| state.
- static SkColor GetBorderColor(bool incognito);
+ // Returns the location bar border color blended with the toolbar color.
+ // It's guaranteed to be opaque.
+ static SkColor GetOpaqueBorderColor(bool incognito);
// Initializes the LocationBarView.
void Init();
@@ -369,6 +369,7 @@ class LocationBarView : public LocationBar,
void OnBoundsChanged(const gfx::Rect& previous_bounds) override;
void OnFocus() override;
void OnPaint(gfx::Canvas* canvas) override;
+ void OnPaintBorder(gfx::Canvas* canvas) override;
// views::DragController:
void WriteDragDataForView(View* sender,

Powered by Google App Engine
This is Rietveld 408576698