Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 267343006: Pass data down pipes in mojo fuzzing tests. (Closed)

Created:
6 years, 7 months ago by Tom Sepez
Modified:
6 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Pass data down pipes in mojo fuzzing tests. Also try to touch (potentially corrupt) arrays, but do not insist on specific values being present. I also tidy up the JS a bit, getting rid of some underscores and double-quotes that crept in despite what the style guide says. R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269955

Patch Set 1 #

Patch Set 2 : Consolidate some checks, touch more memory. #

Patch Set 3 : Endless tinkering #

Patch Set 4 : rebase. #

Patch Set 5 : Rebase on clean branch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -33 lines) Patch
M mojo/apps/js/test/js_to_cpp_unittest.cc View 1 2 3 4 4 chunks +37 lines, -2 lines 0 comments Download
M mojo/apps/js/test/js_to_cpp_unittest.js View 2 4 chunks +59 lines, -31 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Tom Sepez
Trung, please review.
6 years, 7 months ago (2014-05-08 21:43:59 UTC) #1
viettrungluu
lgtm
6 years, 7 months ago (2014-05-09 20:06:43 UTC) #2
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 7 months ago (2014-05-10 17:32:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/267343006/60001
6 years, 7 months ago (2014-05-10 17:33:51 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-10 18:51:20 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-10 18:55:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/3186) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/67042) linux_chromium_chromeos_rel ...
6 years, 7 months ago (2014-05-10 18:55:30 UTC) #7
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 7 months ago (2014-05-12 17:24:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/267343006/60001
6 years, 7 months ago (2014-05-12 17:25:39 UTC) #9
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 7 months ago (2014-05-12 17:52:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/267343006/80001
6 years, 7 months ago (2014-05-12 17:53:37 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-12 23:29:20 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 01:25:27 UTC) #13
Message was sent while issue was closed.
Change committed as 269955

Powered by Google App Engine
This is Rietveld 408576698