Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: tools/perf/measurements/repaint_unittest.py

Issue 267343002: [Telemetry] Disable flaky smoothness.top_25 and testRepaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add in tough scheduler cases on linux Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmarks/smoothness.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from measurements import repaint 5 from measurements import repaint
6 from telemetry import test 6 from telemetry import test
7 from telemetry.core import wpr_modes 7 from telemetry.core import wpr_modes
8 from telemetry.page import page_measurement_unittest_base 8 from telemetry.page import page_measurement_unittest_base
9 from telemetry.page import page as page_module 9 from telemetry.page import page as page_module
10 # pylint: disable=W0401,W0614 10 # pylint: disable=W0401,W0614
(...skipping 16 matching lines...) Expand all
27 27
28 Runs repaint measurement on a simple page and verifies 28 Runs repaint measurement on a simple page and verifies
29 that all metrics were added to the results. The test is purely functional, 29 that all metrics were added to the results. The test is purely functional,
30 i.e. it only checks if the metrics are present and non-zero. 30 i.e. it only checks if the metrics are present and non-zero.
31 """ 31 """
32 32
33 def setUp(self): 33 def setUp(self):
34 self._options = options_for_unittests.GetCopy() 34 self._options = options_for_unittests.GetCopy()
35 self._options.browser_options.wpr_mode = wpr_modes.WPR_OFF 35 self._options.browser_options.wpr_mode = wpr_modes.WPR_OFF
36 36
37 @test.Disabled('android') 37 @test.Disabled # http://crbug.com/368767
38 def testRepaint(self): 38 def testRepaint(self):
39 ps = self.CreateEmptyPageSet() 39 ps = self.CreateEmptyPageSet()
40 ps.AddPage(TestRepaintPage(ps, ps.base_dir)) 40 ps.AddPage(TestRepaintPage(ps, ps.base_dir))
41 measurement = repaint.Repaint() 41 measurement = repaint.Repaint()
42 results = self.RunMeasurement(measurement, ps, options=self._options) 42 results = self.RunMeasurement(measurement, ps, options=self._options)
43 self.assertEquals(0, len(results.failures)) 43 self.assertEquals(0, len(results.failures))
44 44
45 frame_times = results.FindAllPageSpecificValuesNamed('frame_times') 45 frame_times = results.FindAllPageSpecificValuesNamed('frame_times')
46 self.assertEquals(len(frame_times), 1) 46 self.assertEquals(len(frame_times), 1)
47 self.assertGreater(frame_times[0].GetRepresentativeNumber(), 0) 47 self.assertGreater(frame_times[0].GetRepresentativeNumber(), 0)
48 48
49 mean_frame_time = results.FindAllPageSpecificValuesNamed('mean_frame_time') 49 mean_frame_time = results.FindAllPageSpecificValuesNamed('mean_frame_time')
50 self.assertEquals(len(mean_frame_time), 1) 50 self.assertEquals(len(mean_frame_time), 1)
51 self.assertGreater(mean_frame_time[0].GetRepresentativeNumber(), 0) 51 self.assertGreater(mean_frame_time[0].GetRepresentativeNumber(), 0)
52 52
53 jank = results.FindAllPageSpecificValuesNamed('jank') 53 jank = results.FindAllPageSpecificValuesNamed('jank')
54 self.assertEquals(len(jank), 1) 54 self.assertEquals(len(jank), 1)
55 self.assertGreater(jank[0].GetRepresentativeNumber(), 0) 55 self.assertGreater(jank[0].GetRepresentativeNumber(), 0)
56 56
57 mostly_smooth = results.FindAllPageSpecificValuesNamed('mostly_smooth') 57 mostly_smooth = results.FindAllPageSpecificValuesNamed('mostly_smooth')
58 self.assertEquals(len(mostly_smooth), 1) 58 self.assertEquals(len(mostly_smooth), 1)
59 self.assertGreaterEqual(mostly_smooth[0].GetRepresentativeNumber(), 0) 59 self.assertGreaterEqual(mostly_smooth[0].GetRepresentativeNumber(), 0)
60 60
61 @test.Disabled('android') 61 @test.Disabled('android')
62 def testCleanUpTrace(self): 62 def testCleanUpTrace(self):
63 self.TestTracingCleanedUp(repaint.Repaint, self._options) 63 self.TestTracingCleanedUp(repaint.Repaint, self._options)
OLDNEW
« no previous file with comments | « tools/perf/benchmarks/smoothness.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698