Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2673423003: Improve error message when super constructor is invalid (Closed)

Created:
3 years, 10 months ago by hausner
Modified:
3 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve error message when super constructor is invalid Instead of “unresolved call to super constructor”, adapt error message if the super class contains a factory constructor with the same name. Also add this error message clarification to constructor redirection clauses. BUG=#11202 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/a5187ae01d48c702bb185d9beb9ea68c44f0b246

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M runtime/vm/parser.cc View 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
Easy fix to make error message more helpful.
3 years, 10 months ago (2017-02-06 22:34:58 UTC) #3
Florian Schneider
Lgtm
3 years, 10 months ago (2017-02-06 22:38:55 UTC) #4
hausner
3 years, 10 months ago (2017-02-06 22:48:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a5187ae01d48c702bb185d9beb9ea68c44f0b246 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698