src/parsing/pattern-rewriter.cc - Issue 2673403003: [parsing] Fix maybe-assigned for loop variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/pattern-rewriter.cc

Issue 2673403003: [parsing] Fix maybe-assigned for loop variables. (Closed)

Patch Set: Typo. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parsing/pattern-rewriter.cc

diff --git a/src/parsing/pattern-rewriter.cc b/src/parsing/pattern-rewriter.cc

index e22a67b9762ae165fcea959c91bfe0bd8e7e475c..2dad31d8d3a0d1723c392ae3083c746db62ca6ba 100644

--- a/src/parsing/pattern-rewriter.cc

+++ b/src/parsing/pattern-rewriter.cc

@@ -177,6 +177,8 @@ void Parser::PatternRewriter::VisitVariableProxy(VariableProxy* pattern) {

// If there's no initializer, we're done.

if (value == nullptr) return;

+ MarkLoopVariableAsAssigned(var_init_scope, proxy->var());

// A declaration of the form:

// var v = x;