Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: pkg/polymer_expressions/test/syntax_test.dart

Issue 26734004: use symbol literals instead of const ctor in packages (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer_expressions/test/eval_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer_expressions/test/syntax_test.dart
diff --git a/pkg/polymer_expressions/test/syntax_test.dart b/pkg/polymer_expressions/test/syntax_test.dart
index dfc6689fc4e5a406f10f3eeffa225f05c0ace8ba..32b5f63262cdeae841d547a020969d43d4e2b6fe 100644
--- a/pkg/polymer_expressions/test/syntax_test.dart
+++ b/pkg/polymer_expressions/test/syntax_test.dart
@@ -82,12 +82,7 @@ main() {
});
}
-class Person extends Object with ChangeNotifierMixin {
- static const _FIRST_NAME = const Symbol('firstName');
- static const _LAST_NAME = const Symbol('lastName');
- static const _ITEMS = const Symbol('items');
- static const _GET_FULL_NAME = const Symbol('getFullName');
-
+class Person extends ChangeNotifierBase {
String _firstName;
String _lastName;
List<String> _items;
@@ -98,14 +93,14 @@ class Person extends Object with ChangeNotifierMixin {
void set firstName(String value) {
_firstName = value;
- notifyChange(new PropertyChangeRecord(_FIRST_NAME));
+ notifyChange(new PropertyChangeRecord(#firstName));
}
String get lastName => _lastName;
void set lastName(String value) {
_lastName = value;
- notifyChange(new PropertyChangeRecord(_LAST_NAME));
+ notifyChange(new PropertyChangeRecord(#lastName));
}
String getFullName() => '$_firstName $_lastName';
@@ -114,7 +109,7 @@ class Person extends Object with ChangeNotifierMixin {
void set items(List<String> value) {
_items = value;
- notifyChange(new PropertyChangeRecord(_ITEMS));
+ notifyChange(new PropertyChangeRecord(#items));
}
String toString() => "Person(firstName: $_firstName, lastName: $_lastName)";
« no previous file with comments | « pkg/polymer_expressions/test/eval_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698