pkg/observe/lib/src/list_path_observer.dart - Issue 26734004: use symbol literals instead of const ctor in packages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/observe/lib/src/list_path_observer.dart

Issue 26734004: use symbol literals instead of const ctor in packages (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/observe/lib/src/list_path_observer.dart

diff --git a/pkg/observe/lib/src/list_path_observer.dart b/pkg/observe/lib/src/list_path_observer.dart

index 5b83a25b58cf99494a59be4ea81664cbc5c62731..9b8118000614c995ff567ce594c8b28e51e7159d 100644

--- a/pkg/observe/lib/src/list_path_observer.dart

+++ b/pkg/observe/lib/src/list_path_observer.dart

@@ -4,8 +4,6 @@

part of observe;

-const _VALUE = const Symbol('value');

// Inspired by ArrayReduction at:

// https://raw.github.com/rafaelw/ChangeSummary/master/util/array_reduction.js

// The main difference is we support anything on the rich Dart Iterable API.

@@ -49,7 +47,7 @@ class ListPathObserver<E, P> extends ChangeNotifierBase {

void _reduce() {

_scheduled = false;

_value = _observers.map((o) => o.value);

- notifyChange(new PropertyChangeRecord(_VALUE));

+ notifyChange(new PropertyChangeRecord(#value));

}

void _scheduleReduce(_) {

« no previous file with comments | « pkg/observe/lib/src/compound_binding.dart ('k') | pkg/observe/lib/src/observable_box.dart » ('j') | no next file with comments »