Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Side by Side Diff: src/objects-printer.cc

Issue 2673383002: [ic] Encode LoadGlobalIC's typeof mode in slot kind instead of code object's flags. (Closed)
Patch Set: Addressed comments and added check to FCG Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/objects.h" 5 #include "src/objects.h"
6 6
7 #include <iomanip> 7 #include <iomanip>
8 #include <memory> 8 #include <memory>
9 9
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 743 matching lines...) Expand 10 before | Expand all | Expand 10 after
754 FeedbackVectorSlotKind kind = iter.kind(); 754 FeedbackVectorSlotKind kind = iter.kind();
755 755
756 os << "\n Slot " << slot << " " << kind; 756 os << "\n Slot " << slot << " " << kind;
757 os << " "; 757 os << " ";
758 switch (kind) { 758 switch (kind) {
759 case FeedbackVectorSlotKind::LOAD_IC: { 759 case FeedbackVectorSlotKind::LOAD_IC: {
760 LoadICNexus nexus(this, slot); 760 LoadICNexus nexus(this, slot);
761 os << Code::ICState2String(nexus.StateFromFeedback()); 761 os << Code::ICState2String(nexus.StateFromFeedback());
762 break; 762 break;
763 } 763 }
764 case FeedbackVectorSlotKind::LOAD_GLOBAL_IC: { 764 case FeedbackVectorSlotKind::LOAD_GLOBAL_INSIDE_TYPEOF_IC:
765 case FeedbackVectorSlotKind::LOAD_GLOBAL_NOT_INSIDE_TYPEOF_IC: {
765 LoadGlobalICNexus nexus(this, slot); 766 LoadGlobalICNexus nexus(this, slot);
766 os << Code::ICState2String(nexus.StateFromFeedback()); 767 os << Code::ICState2String(nexus.StateFromFeedback());
767 break; 768 break;
768 } 769 }
769 case FeedbackVectorSlotKind::KEYED_LOAD_IC: { 770 case FeedbackVectorSlotKind::KEYED_LOAD_IC: {
770 KeyedLoadICNexus nexus(this, slot); 771 KeyedLoadICNexus nexus(this, slot);
771 os << Code::ICState2String(nexus.StateFromFeedback()); 772 os << Code::ICState2String(nexus.StateFromFeedback());
772 break; 773 break;
773 } 774 }
774 case FeedbackVectorSlotKind::CALL_IC: { 775 case FeedbackVectorSlotKind::CALL_IC: {
(...skipping 949 matching lines...) Expand 10 before | Expand all | Expand 10 after
1724 printf("Not a transition array\n"); 1725 printf("Not a transition array\n");
1725 } else { 1726 } else {
1726 reinterpret_cast<i::TransitionArray*>(object)->Print(); 1727 reinterpret_cast<i::TransitionArray*>(object)->Print();
1727 } 1728 }
1728 } 1729 }
1729 1730
1730 extern void _v8_internal_Print_StackTrace() { 1731 extern void _v8_internal_Print_StackTrace() {
1731 i::Isolate* isolate = i::Isolate::Current(); 1732 i::Isolate* isolate = i::Isolate::Current();
1732 isolate->PrintStack(stdout); 1733 isolate->PrintStack(stdout);
1733 } 1734 }
OLDNEW
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698