Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: src/compiler/ast-graph-builder.cc

Issue 2673383002: [ic] Encode LoadGlobalIC's typeof mode in slot kind instead of code object's flags. (Closed)
Patch Set: Addressed comments and added check to FCG Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/builtins-handler.cc ('k') | src/compiler/bytecode-graph-builder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/ast-graph-builder.h" 5 #include "src/compiler/ast-graph-builder.h"
6 6
7 #include "src/ast/compile-time-value.h" 7 #include "src/ast/compile-time-value.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 #include "src/compilation-info.h" 9 #include "src/compilation-info.h"
10 #include "src/compiler.h" 10 #include "src/compiler.h"
(...skipping 2751 matching lines...) Expand 10 before | Expand all | Expand 10 after
2762 const Operator* op = 2762 const Operator* op =
2763 javascript()->StoreNamed(language_mode(), name, feedback); 2763 javascript()->StoreNamed(language_mode(), name, feedback);
2764 Node* node = NewNode(op, object, value); 2764 Node* node = NewNode(op, object, value);
2765 return node; 2765 return node;
2766 } 2766 }
2767 2767
2768 2768
2769 Node* AstGraphBuilder::BuildGlobalLoad(Handle<Name> name, 2769 Node* AstGraphBuilder::BuildGlobalLoad(Handle<Name> name,
2770 const VectorSlotPair& feedback, 2770 const VectorSlotPair& feedback,
2771 TypeofMode typeof_mode) { 2771 TypeofMode typeof_mode) {
2772 DCHECK_EQ(feedback.vector()->GetTypeofMode(feedback.slot()), typeof_mode);
2772 const Operator* op = javascript()->LoadGlobal(name, feedback, typeof_mode); 2773 const Operator* op = javascript()->LoadGlobal(name, feedback, typeof_mode);
2773 Node* node = NewNode(op); 2774 Node* node = NewNode(op);
2774 return node; 2775 return node;
2775 } 2776 }
2776 2777
2777 2778
2778 Node* AstGraphBuilder::BuildGlobalStore(Handle<Name> name, Node* value, 2779 Node* AstGraphBuilder::BuildGlobalStore(Handle<Name> name, Node* value,
2779 const VectorSlotPair& feedback) { 2780 const VectorSlotPair& feedback) {
2780 const Operator* op = 2781 const Operator* op =
2781 javascript()->StoreGlobal(language_mode(), name, feedback); 2782 javascript()->StoreGlobal(language_mode(), name, feedback);
(...skipping 532 matching lines...) Expand 10 before | Expand all | Expand 10 after
3314 float invocation_frequency, LoopAssignmentAnalysis* loop_assignment, 3315 float invocation_frequency, LoopAssignmentAnalysis* loop_assignment,
3315 SourcePositionTable* source_positions, int inlining_id) 3316 SourcePositionTable* source_positions, int inlining_id)
3316 : AstGraphBuilder(local_zone, info, jsgraph, invocation_frequency, 3317 : AstGraphBuilder(local_zone, info, jsgraph, invocation_frequency,
3317 loop_assignment), 3318 loop_assignment),
3318 source_positions_(source_positions), 3319 source_positions_(source_positions),
3319 start_position_(info->shared_info()->start_position(), inlining_id) {} 3320 start_position_(info->shared_info()->start_position(), inlining_id) {}
3320 3321
3321 } // namespace compiler 3322 } // namespace compiler
3322 } // namespace internal 3323 } // namespace internal
3323 } // namespace v8 3324 } // namespace v8
OLDNEW
« no previous file with comments | « src/builtins/builtins-handler.cc ('k') | src/compiler/bytecode-graph-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698