Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Side by Side Diff: src/builtins/builtins-handler.cc

Issue 2673383002: [ic] Encode LoadGlobalIC's typeof mode in slot kind instead of code object's flags. (Closed)
Patch Set: Addressed comments and added check to FCG Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/builtins.h ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/builtins/builtins-utils.h" 5 #include "src/builtins/builtins-utils.h"
6 #include "src/builtins/builtins.h" 6 #include "src/builtins/builtins.h"
7 #include "src/code-stub-assembler.h" 7 #include "src/code-stub-assembler.h"
8 #include "src/ic/handler-compiler.h" 8 #include "src/ic/handler-compiler.h"
9 #include "src/ic/ic.h" 9 #include "src/ic/ic.h"
10 #include "src/ic/keyed-store-generic.h" 10 #include "src/ic/keyed-store-generic.h"
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 Node* vector = Parameter(Descriptor::kVector); 83 Node* vector = Parameter(Descriptor::kVector);
84 Node* context = Parameter(Descriptor::kContext); 84 Node* context = Parameter(Descriptor::kContext);
85 85
86 TailCallRuntime(Runtime::kLoadGlobalIC_Miss, context, name, slot, vector); 86 TailCallRuntime(Runtime::kLoadGlobalIC_Miss, context, name, slot, vector);
87 } 87 }
88 88
89 TF_BUILTIN(LoadGlobalIC_Slow, CodeStubAssembler) { 89 TF_BUILTIN(LoadGlobalIC_Slow, CodeStubAssembler) {
90 typedef LoadGlobalWithVectorDescriptor Descriptor; 90 typedef LoadGlobalWithVectorDescriptor Descriptor;
91 91
92 Node* name = Parameter(Descriptor::kName); 92 Node* name = Parameter(Descriptor::kName);
93 Node* slot = Parameter(Descriptor::kSlot);
94 Node* vector = Parameter(Descriptor::kVector);
93 Node* context = Parameter(Descriptor::kContext); 95 Node* context = Parameter(Descriptor::kContext);
94 96
95 TailCallRuntime(Runtime::kLoadGlobalIC_Slow, context, name); 97 TailCallRuntime(Runtime::kLoadGlobalIC_Slow, context, name, slot, vector);
96 } 98 }
97 99
98 void Builtins::Generate_LoadIC_Getter_ForDeopt(MacroAssembler* masm) { 100 void Builtins::Generate_LoadIC_Getter_ForDeopt(MacroAssembler* masm) {
99 NamedLoadHandlerCompiler::GenerateLoadViaGetterForDeopt(masm); 101 NamedLoadHandlerCompiler::GenerateLoadViaGetterForDeopt(masm);
100 } 102 }
101 103
102 TF_BUILTIN(LoadIC_Miss, CodeStubAssembler) { 104 TF_BUILTIN(LoadIC_Miss, CodeStubAssembler) {
103 typedef LoadWithVectorDescriptor Descriptor; 105 typedef LoadWithVectorDescriptor Descriptor;
104 106
105 Node* receiver = Parameter(Descriptor::kReceiver); 107 Node* receiver = Parameter(Descriptor::kReceiver);
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 TailCallRuntime(Runtime::kStoreIC_Miss, context, value, slot, vector, 209 TailCallRuntime(Runtime::kStoreIC_Miss, context, value, slot, vector,
208 receiver, name); 210 receiver, name);
209 } 211 }
210 212
211 void Builtins::Generate_StoreIC_Setter_ForDeopt(MacroAssembler* masm) { 213 void Builtins::Generate_StoreIC_Setter_ForDeopt(MacroAssembler* masm) {
212 NamedStoreHandlerCompiler::GenerateStoreViaSetterForDeopt(masm); 214 NamedStoreHandlerCompiler::GenerateStoreViaSetterForDeopt(masm);
213 } 215 }
214 216
215 } // namespace internal 217 } // namespace internal
216 } // namespace v8 218 } // namespace v8
OLDNEW
« no previous file with comments | « src/builtins/builtins.h ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698