Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: media/capture/video/video_capture_device.h

Issue 2673373003: getUserMeida: report device starting states (Closed)
Patch Set: address comments on PS#8 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/video_capture_device.h
diff --git a/media/capture/video/video_capture_device.h b/media/capture/video/video_capture_device.h
index 960e23a308a8e8c250abfde6ff6d554e59142e9b..d99ed31c47e7f85d516474d92523934857d113e5 100644
--- a/media/capture/video/video_capture_device.h
+++ b/media/capture/video/video_capture_device.h
@@ -75,7 +75,11 @@ class CAPTURE_EXPORT VideoCaptureDevice
// Interface defining the methods that clients of VideoCapture must have. It
// is actually two-in-one: clients may implement OnIncomingCapturedData() or
// ReserveOutputBuffer() + OnIncomingCapturedVideoFrame(), or all of them.
- // All clients must implement OnError().
+ // All methods may be called as soon as AllocateAndStart() of the
+ // corresponding VideoCaptureDevice is invoked. The methods for buffer
+ // reservation and frame delivery may be called from arbitrary threads but
+ // are guaranteed to be called non-concurrently. The status reporting methods
+ // (OnStarted, OnLog, OnError) may be called concurrently.
class CAPTURE_EXPORT Client {
public:
// Struct bundling several parameters being passed between a
@@ -200,6 +204,9 @@ class CAPTURE_EXPORT VideoCaptureDevice
// Returns the current buffer pool utilization, in the range 0.0 (no buffers
// are in use by producers or consumers) to 1.0 (all buffers are in use).
virtual double GetBufferPoolUtilization() const = 0;
+
+ // VideoCaptureDevice reports it's successfully started.
+ virtual void OnStarted() = 0;
};
~VideoCaptureDevice() override;
« no previous file with comments | « media/capture/video/mac/video_capture_device_mac.mm ('k') | media/capture/video/video_capture_device_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698