Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java

Issue 2673373003: getUserMeida: report device starting states (Closed)
Patch Set: address comments on PS#6 and restore added state check in frame callback. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
diff --git a/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java b/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
index 929f041150de28ccec086a696f2bc2f219dc9537..034646d78056558b858bdac093e53c2c18f40439 100644
--- a/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
+++ b/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
@@ -400,17 +400,18 @@ public class VideoCaptureCamera
if (mIsRunning) {
return true;
}
+ setPreviewCallback(this);
+ try {
+ mCamera.startPreview();
+ } catch (RuntimeException ex) {
+ Log.e(TAG, "startCapture: Camera.startPreview: " + ex);
+ return false;
+ }
chfremer 2017/02/22 19:13:58 Why are we moving this to under the mPreviewBuffer
braveyao 2017/02/23 00:06:26 Done. No it's not needed. Just didn't want to take
+ nativeOnStarted(mNativeVideoCaptureDeviceAndroid);
mIsRunning = true;
} finally {
mPreviewBufferLock.unlock();
}
- setPreviewCallback(this);
- try {
- mCamera.startPreview();
- } catch (RuntimeException ex) {
- Log.e(TAG, "startCapture: Camera.startPreview: " + ex);
- return false;
- }
return true;
}

Powered by Google App Engine
This is Rietveld 408576698