Chromium Code Reviews| Index: media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java |
| diff --git a/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java b/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java |
| index 929f041150de28ccec086a696f2bc2f219dc9537..034646d78056558b858bdac093e53c2c18f40439 100644 |
| --- a/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java |
| +++ b/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java |
| @@ -400,17 +400,18 @@ public class VideoCaptureCamera |
| if (mIsRunning) { |
| return true; |
| } |
| + setPreviewCallback(this); |
| + try { |
| + mCamera.startPreview(); |
| + } catch (RuntimeException ex) { |
| + Log.e(TAG, "startCapture: Camera.startPreview: " + ex); |
| + return false; |
| + } |
|
chfremer
2017/02/22 19:13:58
Why are we moving this to under the mPreviewBuffer
braveyao
2017/02/23 00:06:26
Done.
No it's not needed. Just didn't want to take
|
| + nativeOnStarted(mNativeVideoCaptureDeviceAndroid); |
| mIsRunning = true; |
| } finally { |
| mPreviewBufferLock.unlock(); |
| } |
| - setPreviewCallback(this); |
| - try { |
| - mCamera.startPreview(); |
| - } catch (RuntimeException ex) { |
| - Log.e(TAG, "startCapture: Camera.startPreview: " + ex); |
| - return false; |
| - } |
| return true; |
| } |