Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java

Issue 2673373003: getUserMeida: report device starting states (Closed)
Patch Set: address comments on PS#4 and revise unittests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
diff --git a/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java b/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
index 929f041150de28ccec086a696f2bc2f219dc9537..d2597a5e6b4bb010ee2b46b8dd94fcdade7d65ec 100644
--- a/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
+++ b/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
@@ -400,7 +400,6 @@ public class VideoCaptureCamera
if (mIsRunning) {
return true;
}
- mIsRunning = true;
} finally {
mPreviewBufferLock.unlock();
}
@@ -411,6 +410,8 @@ public class VideoCaptureCamera
Log.e(TAG, "startCapture: Camera.startPreview: " + ex);
return false;
}
+ nativeOnStarted(mNativeVideoCaptureDeviceAndroid);
+ mIsRunning = true;
chfremer 2017/02/17 23:51:15 I am not sure we can move mIsRunning = true out fr
braveyao 2017/02/22 18:06:44 Done.
return true;
}

Powered by Google App Engine
This is Rietveld 408576698