Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2287)

Unified Diff: net/spdy/spdy_session.cc

Issue 2673363003: Don't access .spec on a !is_valid PUSH_PROMISE URL. (Closed)
Patch Set: Factor out some common things, check rv of wait in the new test. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_network_transaction_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index 92b8f5f34fcb1a2ec234a6ed2a807c3ae2a8725d..ca9a00ef5bf0fd6a13fff44369704430b97d21b4 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -2601,9 +2601,9 @@ void SpdySession::TryCreatePushStream(SpdyStreamId stream_id,
// Verify that the response had a URL for us.
GURL gurl = GetUrlFromHeaderBlock(headers);
if (!gurl.is_valid()) {
- EnqueueResetStreamFrame(stream_id, request_priority,
- ERROR_CODE_PROTOCOL_ERROR,
- "Pushed stream url was invalid: " + gurl.spec());
+ EnqueueResetStreamFrame(
+ stream_id, request_priority, ERROR_CODE_PROTOCOL_ERROR,
+ "Pushed stream url was invalid: " + gurl.possibly_invalid_spec());
return;
}
« no previous file with comments | « net/spdy/spdy_network_transaction_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698