Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: net/spdy/spdy_session.cc

Issue 2673363003: Don't access .spec on a !is_valid PUSH_PROMISE URL. (Closed)
Patch Set: comment formatting tweak Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index edb1ae9b44877b08c4088e3f34ce45052d7e5cbf..bcde2ad1710088b8b1d70bec46e847483cb99105 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -2591,9 +2591,9 @@ void SpdySession::TryCreatePushStream(SpdyStreamId stream_id,
// Verify that the response had a URL for us.
GURL gurl = GetUrlFromHeaderBlock(headers);
if (!gurl.is_valid()) {
- EnqueueResetStreamFrame(stream_id, request_priority,
- ERROR_CODE_PROTOCOL_ERROR,
- "Pushed stream url was invalid: " + gurl.spec());
+ EnqueueResetStreamFrame(
+ stream_id, request_priority, ERROR_CODE_PROTOCOL_ERROR,
+ "Pushed stream url was invalid: " + gurl.possibly_invalid_spec());
return;
}

Powered by Google App Engine
This is Rietveld 408576698