Don't access .spec on a !is_valid PUSH_PROMISE URL.

net/spdy/spdy_network_transaction_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <cmath>
 #include <memory>
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 2843 matching lines @@
 
   // Verify the response headers.
   EXPECT_TRUE(response.headers);
   EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine());
 
   // Verify the pushed stream.
   EXPECT_TRUE(response2.headers);
   EXPECT_EQ("HTTP/1.1 200", response2.headers->GetStatusLine());
 }
 
+TEST_F(SpdyNetworkTransactionTest, ServerPushInvalidUrl) {
+  // Coverage on how a non-empty invalid GURL in a PUSH_PROMISE is handled.
+  SpdyHeaderBlock headers(spdy_util_.ConstructGetHeaderBlock(kDefaultUrl));
+  SpdySerializedFrame req(
+      spdy_util_.ConstructSpdyHeaders(1, std::move(headers), LOWEST, true));
+
+  // Can't use ConstructSpdyPush here since it wants to parse a URL and
+  // split it into the appropriate :header pieces. So we have to hand-fill
+  // those pieces in.
+  SpdyFramer response_spdy_framer(SpdyFramer::ENABLE_COMPRESSION);
+  SpdyHeaderBlock push_promise_header_block;
+  push_promise_header_block[spdy_util_.GetHostKey()] = "";
+  push_promise_header_block[spdy_util_.GetSchemeKey()] = "";
+  push_promise_header_block[spdy_util_.GetPathKey()] = "/index.html";
+
+  SpdyPushPromiseIR push_promise(1, 2, std::move(push_promise_header_block));
+  SpdySerializedFrame push_promise_frame(
+      response_spdy_framer.SerializeFrame(push_promise));
+
+  SpdySerializedFrame stream2_rst(
+      spdy_util_.ConstructSpdyRstStream(2, ERROR_CODE_PROTOCOL_ERROR));
+
+  MockWrite writes[] = {CreateMockWrite(req, 0),
+                        CreateMockWrite(stream2_rst, 2)};
+  MockRead reads[] = {
+      CreateMockRead(push_promise_frame, 1), MockRead(ASYNC, 0, 3) /* EOF */
+  };
+  SequencedSocketData data(reads, arraysize(reads), writes, arraysize(writes));
+
+  NormalSpdyTransactionHelper helper(CreateGetRequest(), DEFAULT_PRIORITY,

[Maks Orlovich, 2017/02/06 19:22:31]

Lots of boilerplate overlap here with methods below and also RunServerPushTest
--- should I try to refactor it out? 
(Might be slightly tricky due to object lifetime..)

[Bence, 2017/02/06 20:48:48]

Whatever you think makes sense.  There's a lot of boilerplate in these tests
already anyway.  If there's an easy way to simplify tests that makes them easier
to read, then by all means, go for it!

+                                     NetLogWithSource(), nullptr);
+  helper.RunPreTestSetup();
+  helper.AddData(&data);
+
+  HttpNetworkTransaction* trans = helper.trans();
+
+  TestCompletionCallback callback;
+  int rv = trans->Start(&CreateGetRequest(), callback.callback(),
+                        NetLogWithSource());
+  EXPECT_THAT(rv, IsError(ERR_IO_PENDING));
+  rv = callback.WaitForResult();

[Bence, 2017/02/06 20:48:48]

Did you not want to test the value of |rv| after this assignment?

+
+  base::RunLoop().RunUntilIdle();
+
+  EXPECT_TRUE(data.AllReadDataConsumed());
+  EXPECT_TRUE(data.AllWriteDataConsumed());
+}
+
 TEST_F(SpdyNetworkTransactionTest, ServerPushInvalidAssociatedStreamID0) {
   SpdySerializedFrame stream1_syn(
       spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST, true));
   SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway(
       0, ERROR_CODE_PROTOCOL_ERROR, "Framer error: 1 (INVALID_STREAM_ID)."));
   MockWrite writes[] = {
       CreateMockWrite(stream1_syn, 0), CreateMockWrite(goaway, 3),
   };
 
   SpdySerializedFrame stream1_reply(
@@ skipping 3682 matching lines @@
 TEST_F(SpdyNetworkTransactionTLSUsageCheckTest, TLSCipherSuiteSucky) {
   std::unique_ptr<SSLSocketDataProvider> ssl_provider(
       new SSLSocketDataProvider(ASYNC, OK));
   // Set to TLS_RSA_WITH_NULL_MD5
   SSLConnectionStatusSetCipherSuite(0x1, &ssl_provider->connection_status);
 
   RunTLSUsageCheckTest(std::move(ssl_provider));
 }
 
 }  // namespace net