Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 267333008: Convert fast/repaint/background-scaling.html to a reftest (Closed)

Created:
6 years, 7 months ago by Xianzhu
Modified:
6 years, 7 months ago
Reviewers:
ojan, abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

Convert fast/repaint/background-scaling.html to a reftest Originally the test expects full repaint of the viewport on page scale changes. However, the repaint is unnecessary because we handle page scale in the compositor. My later change will optimize this. Convert it to a reftest to ensure the visual result is correct. BUG=258219 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173658

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -25 lines) Patch
M LayoutTests/fast/repaint/background-scaling.html View 1 2 1 chunk +10 lines, -11 lines 0 comments Download
A LayoutTests/fast/repaint/background-scaling-expected.html View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
D LayoutTests/fast/repaint/background-scaling-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/platform/mac/fast/repaint/background-scaling-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/background-scaling-expected.png View Binary file 0 comments Download

Messages

Total messages: 9 (0 generated)
Xianzhu
6 years, 7 months ago (2014-05-07 22:33:05 UTC) #1
abarth-chromium
lgtm
6 years, 7 months ago (2014-05-08 12:56:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/267333008/20001
6 years, 7 months ago (2014-05-08 12:56:58 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 14:08:59 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-08 14:45:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/6194)
6 years, 7 months ago (2014-05-08 14:45:37 UTC) #6
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 7 months ago (2014-05-08 16:28:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/267333008/40001
6 years, 7 months ago (2014-05-08 16:29:52 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 17:45:05 UTC) #9
Message was sent while issue was closed.
Change committed as 173658

Powered by Google App Engine
This is Rietveld 408576698