Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 267333006: Adding a few new MSE tests based on the spec. (Closed)

Created:
6 years, 7 months ago by prabhur1
Modified:
6 years, 7 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Adding a few new MSE tests based on the spec. This is intended to make the MSE implementation more spec compliant. More such CLs to follow after this initial round is checked in. BUG= TEST=new test pass Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173667

Patch Set 1 #

Total comments: 10

Patch Set 2 : Addressing CR comments #

Messages

Total messages: 6 (0 generated)
prabhur1
PTAL. Adding a few MSE tests for spec compliancy. Looking for early feedback before adding ...
6 years, 7 months ago (2014-05-07 18:27:25 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm % a few nits https://codereview.chromium.org/267333006/diff/1/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html File LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html (right): https://codereview.chromium.org/267333006/diff/1/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html#newcode78 LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html:78: var mimetype = 'video/webm;codecs="vp8"'; ...
6 years, 7 months ago (2014-05-08 15:16:31 UTC) #2
prabhur1
Thanks for taking a look! Addressed the minor changes. https://codereview.chromium.org/267333006/diff/1/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html File LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html (right): https://codereview.chromium.org/267333006/diff/1/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html#newcode78 LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html:78: ...
6 years, 7 months ago (2014-05-08 17:59:21 UTC) #3
prabhur1
The CQ bit was checked by prabhur@chromium.org
6 years, 7 months ago (2014-05-08 18:00:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prabhur@chromium.org/267333006/20001
6 years, 7 months ago (2014-05-08 18:02:05 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 19:19:31 UTC) #6
Message was sent while issue was closed.
Change committed as 173667

Powered by Google App Engine
This is Rietveld 408576698