Add the new suggestion url for Naver.

Add the new suggestion url for Naver.

The existing suggestion url for Naver was obsoleted recently.
This CL introduces the new suggestion url for Naver.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268974

[Sungmann Cho, 2014-05-07 02:25:13]

Please take a look. Thanks!

[Peter Kasting, 2014-05-07 03:04:08]

Why is the old -- broken -- URL still listed in the site's OSDD at
http://sstatic.naver.net/search/opensearch-description.xml ?

In general, we try to keep our search data in sync with what the site in
question actually does, or else requests in its OSDD.  If this is the correct
URL, I'd prefer to get it listed there, so Chrome can just match the published
document.

Also, when you update prepopulated_engines.json, you need to bump the version
number at the top.

[Sungmann Cho, 2014-05-07 04:05:45]

On 2014/05/07 03:04:08, Peter Kasting wrote:
> Why is the old -- broken -- URL still listed in the site's OSDD at
> http://sstatic.naver.net/search/opensearch-description.xml ?
> 
> In general, we try to keep our search data in sync with what the site in
> question actually does, or else requests in its OSDD.  If this is the correct
> URL, I'd prefer to get it listed there, so Chrome can just match the published
> document.
> 
> Also, when you update prepopulated_engines.json, you need to bump the version
> number at the top.

Oops! I forgot to increment the version value. Sorry about that!
And you are right. The suggestion url in our OSDD is the obsoleted one.
Thank you for pointing that out. I'll ask the relevant team to fix this
as soon as possible. So do I have to wait till the fix? :(

[Sungmann Cho, 2014-05-07 05:18:58]

Now Naver's OSDD has got the correct information.
Please take a look. Thanks!

[Peter Kasting, 2014-05-07 06:51:01]

https://codereview.chromium.org/267333002/diff/30001/chrome/browser/search_en...
File chrome/browser/search_engines/prepopulated_engines.json (right):

https://codereview.chromium.org/267333002/diff/30001/chrome/browser/search_en...
chrome/browser/search_engines/prepopulated_engines.json:576: "favicon_url":
"http://www.naver.com/favicon.ico",
Don't change this value.  I realize this is the OSDD value, but the source code
for search result pages takes precedence over that.

https://codereview.chromium.org/267333002/diff/30001/chrome/browser/search_en...
chrome/browser/search_engines/prepopulated_engines.json:578: "suggest_url":
"http://ac.search.naver.com/nx/ac?of=os&ie={inputEncoding}&oe={outputEncoding}&q={searchTerms}",
Nit: Can you reverse the last two params to match the OSDD, or else get the OSDD
to reverse the last two params to match this URL (preferred)?

[Sungmann Cho, 2014-05-07 07:05:28]

https://codereview.chromium.org/267333002/diff/30001/chrome/browser/search_en...
File chrome/browser/search_engines/prepopulated_engines.json (right):

https://codereview.chromium.org/267333002/diff/30001/chrome/browser/search_en...
chrome/browser/search_engines/prepopulated_engines.json:576: "favicon_url":
"http://www.naver.com/favicon.ico",
On 2014/05/07 06:51:01, Peter Kasting wrote:
> Don't change this value.  I realize this is the OSDD value, but the source
code
> for search result pages takes precedence over that.

Done.

https://codereview.chromium.org/267333002/diff/30001/chrome/browser/search_en...
chrome/browser/search_engines/prepopulated_engines.json:578: "suggest_url":
"http://ac.search.naver.com/nx/ac?of=os&ie={inputEncoding}&oe={outputEncoding}&q={searchTerms}",
On 2014/05/07 06:51:01, Peter Kasting wrote:
> Nit: Can you reverse the last two params to match the OSDD, or else get the
OSDD
> to reverse the last two params to match this URL (preferred)?

Done.

[Peter Kasting, 2014-05-07 17:04:44]

LGTM

[Peter Kasting, 2014-05-07 17:04:47]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2014-05-07 17:06:50]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/267333002/5...

[commit-bot: I haz the power, 2014-05-07 22:05:32]

Change committed as 268974

[Sungmann Cho, 2014-07-04 02:08:25]

When will this CL land in a public stable release?

[Peter Kasting, 2014-07-04 18:44:16]

On 2014/07/04 02:08:25, Sungmann Cho wrote:
> When will this CL land in a public stable release?

It's in Chrome 36, which is in beta.  Given that Chrome 35 went stable May 20th,
I'd expect M36 to be pushed to stable at any time; I don't know the precise
schedule.

[Sungmann Cho, 2014-07-04 22:52:55]

On 2014/07/04 18:44:16, Peter Kasting wrote:
> On 2014/07/04 02:08:25, Sungmann Cho wrote:
> > When will this CL land in a public stable release?
> 
> It's in Chrome 36, which is in beta.  Given that Chrome 35 went stable May
20th,
> I'd expect M36 to be pushed to stable at any time; I don't know the precise
> schedule.

OK. Got it. Thank you for your quick reply. :)