src/parsing/preparser.cc - Issue 2673313003: [parser] Skipping inner funcs: produce the same scopes / variables for loops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/preparser.cc

Issue 2673313003: [parser] Skipping inner funcs: produce the same scopes / variables for loops. (Closed)

Patch Set: code review (vogelheim@) Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parsing/preparser.cc

diff --git a/src/parsing/preparser.cc b/src/parsing/preparser.cc

index 864b10d376e7e9fd06e082f929fd5e9f56560b2c..0377a1b9d35e70ff9cb131ad061e01f7f257888f 100644

--- a/src/parsing/preparser.cc

+++ b/src/parsing/preparser.cc

@@ -307,6 +307,7 @@ void PreParser::DeclareAndInitializeVariables(

ZoneList<const AstRawString*>* names, bool* ok) {

if (declaration->pattern.variables_ != nullptr) {

DCHECK(FLAG_lazy_inner_functions);

+ DCHECK(track_unresolved_variables_);

for (auto variable : *(declaration->pattern.variables_)) {

declaration_descriptor->scope->RemoveUnresolved(variable);

scope()->DeclareVariableName(variable->raw_name(),

« no previous file with comments | « src/parsing/preparser.h ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »