Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

Issue 2673303002: All offset in dom/Range.idl should be unsigned long (Closed)
Patch Set: Remove unnecessary static_cast Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp b/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
index 1ab7b726512409006aba464b46de63485c7b42ec..1b162595c1e8695a61fa742b83eb9040f8928f4e 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
@@ -209,8 +209,8 @@ TEST_F(VisibleSelectionTest, Initialisation) {
EXPECT_TRUE(selectionInFlatTree.isCaret());
Range* range = firstRangeOf(selection);
- EXPECT_EQ(0, range->startOffset());
- EXPECT_EQ(0, range->endOffset());
+ EXPECT_EQ(0u, range->startOffset());
+ EXPECT_EQ(0u, range->endOffset());
EXPECT_EQ("", range->text());
testFlatTreePositionsToEqualToDOMTreePositions(selection,
selectionInFlatTree);
@@ -351,8 +351,8 @@ TEST_F(VisibleSelectionTest, WordGranularity) {
expandUsingGranularity(selectionInFlatTree, WordGranularity);
Range* range = firstRangeOf(selection);
- EXPECT_EQ(0, range->startOffset());
- EXPECT_EQ(5, range->endOffset());
+ EXPECT_EQ(0u, range->startOffset());
+ EXPECT_EQ(5u, range->endOffset());
EXPECT_EQ("Lorem", range->text());
testFlatTreePositionsToEqualToDOMTreePositions(selection,
selectionInFlatTree);
@@ -367,8 +367,8 @@ TEST_F(VisibleSelectionTest, WordGranularity) {
expandUsingGranularity(selectionInFlatTree, WordGranularity);
Range* range = firstRangeOf(selection);
- EXPECT_EQ(6, range->startOffset());
- EXPECT_EQ(11, range->endOffset());
+ EXPECT_EQ(6u, range->startOffset());
+ EXPECT_EQ(11u, range->endOffset());
EXPECT_EQ("ipsum", range->text());
testFlatTreePositionsToEqualToDOMTreePositions(selection,
selectionInFlatTree);
@@ -385,8 +385,8 @@ TEST_F(VisibleSelectionTest, WordGranularity) {
expandUsingGranularity(selectionInFlatTree, WordGranularity);
Range* range = firstRangeOf(selection);
- EXPECT_EQ(5, range->startOffset());
- EXPECT_EQ(6, range->endOffset());
+ EXPECT_EQ(5u, range->startOffset());
+ EXPECT_EQ(6u, range->endOffset());
EXPECT_EQ(" ", range->text());
testFlatTreePositionsToEqualToDOMTreePositions(selection,
selectionInFlatTree);
@@ -403,8 +403,8 @@ TEST_F(VisibleSelectionTest, WordGranularity) {
expandUsingGranularity(selectionInFlatTree, WordGranularity);
Range* range = firstRangeOf(selection);
- EXPECT_EQ(26, range->startOffset());
- EXPECT_EQ(27, range->endOffset());
+ EXPECT_EQ(26u, range->startOffset());
+ EXPECT_EQ(27u, range->endOffset());
EXPECT_EQ(",", range->text());
testFlatTreePositionsToEqualToDOMTreePositions(selection,
selectionInFlatTree);
@@ -419,8 +419,8 @@ TEST_F(VisibleSelectionTest, WordGranularity) {
expandUsingGranularity(selectionInFlatTree, WordGranularity);
Range* range = firstRangeOf(selection);
- EXPECT_EQ(27, range->startOffset());
- EXPECT_EQ(28, range->endOffset());
+ EXPECT_EQ(27u, range->startOffset());
+ EXPECT_EQ(28u, range->endOffset());
EXPECT_EQ(" ", range->text());
testFlatTreePositionsToEqualToDOMTreePositions(selection,
selectionInFlatTree);
@@ -435,8 +435,8 @@ TEST_F(VisibleSelectionTest, WordGranularity) {
expandUsingGranularity(selectionInFlatTree, WordGranularity);
Range* range = firstRangeOf(selection);
- EXPECT_EQ(0, range->startOffset());
- EXPECT_EQ(5, range->endOffset());
+ EXPECT_EQ(0u, range->startOffset());
+ EXPECT_EQ(5u, range->endOffset());
EXPECT_EQ("Lorem", range->text());
testFlatTreePositionsToEqualToDOMTreePositions(selection,
selectionInFlatTree);
@@ -451,8 +451,8 @@ TEST_F(VisibleSelectionTest, WordGranularity) {
expandUsingGranularity(selectionInFlatTree, WordGranularity);
Range* range = firstRangeOf(selection);
- EXPECT_EQ(0, range->startOffset());
- EXPECT_EQ(11, range->endOffset());
+ EXPECT_EQ(0u, range->startOffset());
+ EXPECT_EQ(11u, range->endOffset());
EXPECT_EQ("Lorem ipsum", range->text());
testFlatTreePositionsToEqualToDOMTreePositions(selection,
selectionInFlatTree);

Powered by Google App Engine
This is Rietveld 408576698