Issue 267323008: Missing OS guard before including android header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 267323008: Missing OS guard before including android header. (Closed)

Created:
6 years, 7 months ago by Daniel Bratell

Modified:
6 years, 7 months ago

Reviewers:
aelias_OOO_until_Jul13

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, tsniatowski

Base URL:
https://chromium.googlesource.com/chromium/src.git@bindings_thin

Visibility:
Public.

More Reviews

Description

Missing OS guard before including android header. An Android header was unconditionally included. It works as long as the header doesn't use any Android specific code but it's doomed to break something eventually. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269430