Chromium Code Reviews

Issue 267323008: Missing OS guard before including android header. (Closed)

Created:
6 years, 7 months ago by Daniel Bratell
Modified:
6 years, 7 months ago
Reviewers:
aelias_OOO_until_Jul13
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, tsniatowski
Base URL:
https://chromium.googlesource.com/chromium/src.git@bindings_thin
Visibility:
Public.

Description

Missing OS guard before including android header. An Android header was unconditionally included. It works as long as the header doesn't use any Android specific code but it's doomed to break something eventually. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269430

Patch Set 1 : #

Unified diffs Side-by-side diffs Stats (+4 lines, -1 line)
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +4 lines, -1 line 0 comments

Messages

Total messages: 6 (0 generated)
Daniel Bratell
aelias, just adding guards around an include, can you take a look please?
6 years, 7 months ago (2014-05-08 09:12:45 UTC) #1
aelias_OOO_until_Jul13
lgtm
6 years, 7 months ago (2014-05-08 18:16:58 UTC) #2
Daniel Bratell
The CQ bit was checked by bratell@opera.com
6 years, 7 months ago (2014-05-08 21:18:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/267323008/20001
6 years, 7 months ago (2014-05-08 21:22:55 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 01:31:34 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 22:03:25 UTC) #6
Message was sent while issue was closed.
Change committed as 269430

Powered by Google App Engine