Oilpan: Move ThreadableWebSocketChannelClientWrapper to Oilpan's heap

Source/platform/CrossThreadCopier.h

Index: Source/platform/CrossThreadCopier.h
diff --git a/Source/platform/CrossThreadCopier.h b/Source/platform/CrossThreadCopier.h
index 0adbf860d1a5026e9614682c7c7555deb1022c9c..f87c653fa6c30f4f89266fd73aaf803b05bc1ff3 100644
--- a/Source/platform/CrossThreadCopier.h
+++ b/Source/platform/CrossThreadCopier.h
@@ -32,6 +32,7 @@
 #define CrossThreadCopier_h
 
 #include "platform/PlatformExport.h"
+#include "platform/heap/Handle.h"
 #include "wtf/Assertions.h"
 #include "wtf/Forward.h"
 #include "wtf/PassOwnPtr.h"
@@ -48,6 +49,7 @@ namespace WebCore {
     class ResourceError;
     class ResourceRequest;
     class ResourceResponse;
+    class ThreadableWebSocketChannelClientWrapper;
     struct CrossThreadResourceResponseData;
     struct CrossThreadResourceRequestData;
     struct ThreadableLoaderOptions;
@@ -104,6 +106,14 @@ namespace WebCore {
         }
     };
 
+    template<> struct CrossThreadCopierBase<false, false, ThreadableWebSocketChannelClientWrapper*> {

[haraken, 2014/05/07 07:45:16]

I must admit that I'm not understanding what I'm doing.

I added this template specialization to make the CL compilable and pass all
tests, but I'm not quite sure if this is right.

template experts: I'd be happy if you could give me any advice.

[tkent, 2014/05/07 08:10:41]

The generated code would be ok.  We don't need special handling on copying a
pointer to an on-heap object over threads.
However, referring to a class in a modules here is a kind of layering violation.
We should have a specialization for IsSubclassOfTemplate<T, GarbageCollected>.

Also, this change is not enough. We need a specialization for
CrossThreadTaskTraits so that m_parameterN in CrossTheradTaskM becomes
CrossThreadPersistent.

[haraken, 2014/05/07 11:18:33]

Done. Please take a look, I'm not familiar with templates :)

+        typedef ThreadableWebSocketChannelClientWrapper* Type;
+        static Type copy(Type rawPtr)
+        {
+            return rawPtr;
+        }
+    };
+
     template<> struct CrossThreadCopierBase<false, false, KURL> {
         typedef KURL Type;
         PLATFORM_EXPORT static Type copy(const KURL&);