Source/modules/websockets/ThreadableWebSocketChannelClientWrapper.h - Issue 267323004: Oilpan: Move ThreadableWebSocketChannelClientWrapper to Oilpan's heap

Unified Diff: Source/modules/websockets/ThreadableWebSocketChannelClientWrapper.h

Issue 267323004: Oilpan: Move ThreadableWebSocketChannelClientWrapper to Oilpan's heap (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | Source/modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp » ('j') | Source/modules/websockets/WorkerThreadableWebSocketChannel.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/websockets/ThreadableWebSocketChannelClientWrapper.h

diff --git a/Source/modules/websockets/ThreadableWebSocketChannelClientWrapper.h b/Source/modules/websockets/ThreadableWebSocketChannelClientWrapper.h

index bed47dfb9db43e86426a3912466e01165ea353f2..6b7efb0190569662c54724f5e7e2da3ca2283cb4 100644

--- a/Source/modules/websockets/ThreadableWebSocketChannelClientWrapper.h

+++ b/Source/modules/websockets/ThreadableWebSocketChannelClientWrapper.h

@@ -45,9 +45,9 @@ namespace WebCore {

class ExecutionContext;

class WebSocketChannelClient;

-class ThreadableWebSocketChannelClientWrapper : public ThreadSafeRefCounted<ThreadableWebSocketChannelClientWrapper> {

+class ThreadableWebSocketChannelClientWrapper : public ThreadSafeRefCountedWillBeGarbageCollectedFinalized<ThreadableWebSocketChannelClientWrapper> {

public:

- static PassRefPtr<ThreadableWebSocketChannelClientWrapper> create(WebSocketChannelClient*);

+ static PassRefPtrWillBeRawPtr<ThreadableWebSocketChannelClientWrapper> create(WebSocketChannelClient*);

// Subprotocol and extensions will be available when didConnect() callback is invoked.

String subprotocol() const;

@@ -68,18 +68,20 @@ public:

void suspend();

void resume();

+ void trace(Visitor*) { }

private:

ThreadableWebSocketChannelClientWrapper(WebSocketChannelClient*);

void processPendingTasks();

- static void didConnectCallback(ExecutionContext*, PassRefPtr<ThreadableWebSocketChannelClientWrapper>);

- static void didReceiveMessageCallback(ExecutionContext*, PassRefPtr<ThreadableWebSocketChannelClientWrapper>, const String& message);

- static void didReceiveBinaryDataCallback(ExecutionContext*, PassRefPtr<ThreadableWebSocketChannelClientWrapper>, PassOwnPtr<Vector<char> >);

- static void didUpdateBufferedAmountCallback(ExecutionContext*, PassRefPtr<ThreadableWebSocketChannelClientWrapper>, unsigned long bufferedAmount);

- static void didStartClosingHandshakeCallback(ExecutionContext*, PassRefPtr<ThreadableWebSocketChannelClientWrapper>);

- static void didCloseCallback(ExecutionContext*, PassRefPtr<ThreadableWebSocketChannelClientWrapper>, unsigned long unhandledBufferedAmount, WebSocketChannelClient::ClosingHandshakeCompletionStatus, unsigned short code, const String& reason);

- static void didReceiveMessageErrorCallback(ExecutionContext*, PassRefPtr<ThreadableWebSocketChannelClientWrapper>);

+ static void didConnectCallback(ExecutionContext*, PassRefPtrWillBeRawPtr<ThreadableWebSocketChannelClientWrapper>);

+ static void didReceiveMessageCallback(ExecutionContext*, PassRefPtrWillBeRawPtr<ThreadableWebSocketChannelClientWrapper>, const String& message);

+ static void didReceiveBinaryDataCallback(ExecutionContext*, PassRefPtrWillBeRawPtr<ThreadableWebSocketChannelClientWrapper>, PassOwnPtr<Vector<char> >);

+ static void didUpdateBufferedAmountCallback(ExecutionContext*, PassRefPtrWillBeRawPtr<ThreadableWebSocketChannelClientWrapper>, unsigned long bufferedAmount);

+ static void didStartClosingHandshakeCallback(ExecutionContext*, PassRefPtrWillBeRawPtr<ThreadableWebSocketChannelClientWrapper>);

+ static void didCloseCallback(ExecutionContext*, PassRefPtrWillBeRawPtr<ThreadableWebSocketChannelClientWrapper>, unsigned long unhandledBufferedAmount, WebSocketChannelClient::ClosingHandshakeCompletionStatus, unsigned short code, const String& reason);

+ static void didReceiveMessageErrorCallback(ExecutionContext*, PassRefPtrWillBeRawPtr<ThreadableWebSocketChannelClientWrapper>);

WebSocketChannelClient* m_client;

haraken 2014/05/07 07:45:16 This raw pointer is safe because it's explicitly c

// ThreadSafeRefCounted must not have String member variables.