Oilpan: Move ThreadableWebSocketChannelClientWrapper to Oilpan's heap

Source/core/dom/CrossThreadTask.h

 /*
  * Copyright (C) 2009-2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 39 matching lines @@
 };
 
 template<typename T> struct CrossThreadTaskTraits<PassRefPtr<T> > {
     typedef PassRefPtr<T> ParamType;
 };
 
 template<typename T> struct CrossThreadTaskTraits<PassOwnPtr<T> > {
     typedef PassOwnPtr<T> ParamType;
 };
 
+template<typename T> struct CrossThreadTaskTraits<CrossThreadPersistent<T> > {
+    typedef CrossThreadPersistent<T> ParamType;
+};
+
 template<typename P1, typename MP1>
 class CrossThreadTask1 : public ExecutionContextTask {
 public:
     typedef void (*Method)(ExecutionContext*, MP1);
     typedef CrossThreadTask1<P1, MP1> CrossThreadTask;
     typedef typename CrossThreadTaskTraits<P1>::ParamType Param1;
 
     static PassOwnPtr<CrossThreadTask> create(Method method, Param1 parameter1)
     {
         return adoptPtr(new CrossThreadTask(method, parameter1));
     }
 
 private:
     CrossThreadTask1(Method method, Param1 parameter1)
         : m_method(method)
         , m_parameter1(parameter1)
     {
     }
 
     virtual void performTask(ExecutionContext* context)
     {
         (*m_method)(context, m_parameter1);

[haraken, 2014/05/09 08:08:23]

This line hits the following compile error:

../../third_party/WebKit/Source/core/dom/CrossThreadTask.h:85:30: error: no
viable conversion from
'WebCore::CrossThreadPersistent<WebCore::ThreadableWebSocketChannelClientWrapper
*>' to 'WTF::RawPtr<WebCore::ThreadableWebSocketChannelClientWrapper>'  
        (*m_method)(context, m_parameter1);

The issue is that we don't have an implicit conversion from
CrossThreadPersistent to RawPtr, but how can I add it? My change to Handle.h
seems not enough.

     }
 
 private:
     Method m_method;
     P1 m_parameter1;
 };
 
 template<typename P1, typename MP1, typename P2, typename MP2>
 class CrossThreadTask2 : public ExecutionContextTask {
 public:
@@ skipping 376 matching lines @@
                                                        method,
                                                        CrossThreadCopier<P1>::copy(parameter1), CrossThreadCopier<P2>::copy(parameter2),
                                                        CrossThreadCopier<P3>::copy(parameter3), CrossThreadCopier<P4>::copy(parameter4),
                                                        CrossThreadCopier<P5>::copy(parameter5), CrossThreadCopier<P6>::copy(parameter6),
                                                        CrossThreadCopier<P7>::copy(parameter7), CrossThreadCopier<P8>::copy(parameter8));
 }
 
 } // namespace WebCore
 
 #endif // CrossThreadTask_h