Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 26732006: Revert "Unify and fix checkers for duplicate object literal properties." (Closed)

Created:
7 years, 2 months ago by mvstanton
Modified:
7 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Revert "Unify and fix checkers for duplicate object literal properties." This reverts commit 12c68518bd2c74dc4e44d928c84c17f98ca63359. (r17114) R=mstarzinger@chromium.org TBR=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17122

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+362 lines, -316 lines) Patch
M src/conversions.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/parser.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/parser.cc View 7 chunks +90 lines, -15 lines 0 comments Download
M src/preparser.h View 5 chunks +88 lines, -94 lines 0 comments Download
M src/preparser.cc View 5 chunks +176 lines, -10 lines 0 comments Download
M src/scanner.h View 3 chunks +1 line, -54 lines 0 comments Download
M src/scanner.cc View 2 chunks +0 lines, -140 lines 0 comments Download
M test/preparser/preparser.status View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
LGTM (rubber-stamped).
7 years, 2 months ago (2013-10-10 08:44:58 UTC) #1
mvstanton
7 years, 2 months ago (2013-10-10 08:45:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r17122 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698