Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: tools/testing/dart/test_options.dart

Issue 2673133002: Get rid of --use-repository-packages and --use-public-packages. (Closed)
Patch Set: Remove unused import. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_configurations.dart ('k') | tools/testing/dart/test_progress.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index ba252ffae00dc05655f6a31ab0c4888405ee26ba..be50738460eb0a1aa7528045d9ead7b52c34f466 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -340,23 +340,6 @@ Note: currently only implemented for dart2js.''',
false,
type: 'bool'),
new _TestOptionSpecification(
- 'use_public_packages',
- 'For tests using packages: Use pub.dartlang.org packages '
- 'instead the ones in the repository.',
- ['--use-public-packages'],
- [],
- false,
- type: 'bool'),
- new _TestOptionSpecification(
- 'use_repository_packages',
- 'For tests using packages: Use pub.dartlang.org packages '
- 'but use overrides for the packages available in the '
- 'repository.',
- ['--use-repository-packages'],
- [],
- false,
- type: 'bool'),
- new _TestOptionSpecification(
'build_directory',
'The name of the build directory, where products are placed.',
['--build-directory'],
@@ -752,12 +735,6 @@ Note: currently only implemented for dart2js.''',
print("Error: shard index is ${config['shard']} out of "
"${config['shards']} shards");
}
-
- if (config['use_repository_packages'] && config['use_public_packages']) {
- isValid = false;
- print("Cannot have both --use-repository-packages and "
- "--use-public-packages");
- }
if ((config['runtime'] == 'flutter') && (config['flutter'] == '')) {
isValid = false;
print("-rflutter requires the flutter engine executable to "
« no previous file with comments | « tools/testing/dart/test_configurations.dart ('k') | tools/testing/dart/test_progress.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698