Get rid of --use-repository-packages and --use-public-packages.

Get rid of --use-repository-packages and --use-public-packages.

The former doesn't seem to tell us anything useful, and is broken. The
latter is no longer needed as a flag without the former. The pkgbuild
suite implies it and other suites don't support it.

R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/e826303741f70e32e9f6da708c0441d9e7d4fabd

[Bob Nystrom, 2017-02-03 21:54:28]

rnystrom@google.com changed reviewers:
+ sigmund@google.com, whesse@google.com

[Bob Nystrom, 2017-02-03 21:54:28]

I talked to Siggy and my feeling is that --use-repository-packages just isn't
useful. At the very least, is it is currently implemented is wrong since it
doesn't include transitive deps.

Even if we fix that, I don't see it telling us anything particularly useful.

So this kills that flag and the bot step that runs it. I also got rid of
--use-public-packages, since I think it is now implied.

test.dart is dark and mysterious to me, so my confidence that I understand
what's going on is fairly low, but I think this works and gets rid of some
useless dead weight.

[Bill Hesse, 2017-02-03 22:02:20]

On 2017/02/03 21:54:28, Bob Nystrom wrote:
> I talked to Siggy and my feeling is that --use-repository-packages just isn't
> useful. At the very least, is it is currently implemented is wrong since it
> doesn't include transitive deps.
> 
> Even if we fix that, I don't see it telling us anything particularly useful.
> 
> So this kills that flag and the bot step that runs it. I also got rid of
> --use-public-packages, since I think it is now implied.
> 
> test.dart is dark and mysterious to me, so my confidence that I understand
> what's going on is fairly low, but I think this works and gets rid of some
> useless dead weight.

Sounds good to me.  I know that use-repository-packages was broken, and most of
the effect is gotten
by running the package unit tests in the checkout as is, with the checkout's
.packages file.

I suppose there may be some packages in third_party that don't have their test
dependencies in .packages, but they are only tested on
 the packages waterfall anyway.

I'll review it

[Bill Hesse, 2017-02-03 22:10:23]

LGTM

https://codereview.chromium.org/2673133002/diff/1/tools/testing/dart/test_run...
File tools/testing/dart/test_runner.dart (left):

https://codereview.chromium.org/2673133002/diff/1/tools/testing/dart/test_run...
tools/testing/dart/test_runner.dart:22: import 'package:yaml/yaml.dart';
Can we get rid of this now?  This was the only use of a package within
test.dart, so it would be great to be package-free.

[Bob Nystrom, 2017-02-06 18:40:48]

https://codereview.chromium.org/2673133002/diff/1/tools/testing/dart/test_run...
File tools/testing/dart/test_runner.dart (left):

https://codereview.chromium.org/2673133002/diff/1/tools/testing/dart/test_run...
tools/testing/dart/test_runner.dart:22: import 'package:yaml/yaml.dart';
On 2017/02/03 22:10:23, Bill Hesse wrote:
> Can we get rid of this now?  This was the only use of a package within
> test.dart, so it would be great to be package-free.

Done.

[Bob Nystrom, 2017-02-06 18:40:57]

Description was changed from

==========
Get rid of --use-repository-packages and --use-public-packages.

The former doesn't seem to tell us anything useful, and is broken. The
latter is no longer needed as a flag without the former. The pkgbuild
suite implies it and other suites don't support it.
==========

to

==========
Get rid of --use-repository-packages and --use-public-packages.

The former doesn't seem to tell us anything useful, and is broken. The
latter is no longer needed as a flag without the former. The pkgbuild
suite implies it and other suites don't support it.

R=whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e826303741f70e32e9f6da708c0441d9e7d4fabd
==========

[Bob Nystrom, 2017-02-06 18:40:58]

Committed patchset #2 (id:20001) manually as
e826303741f70e32e9f6da708c0441d9e7d4fabd (presubmit successful).