Source/core/page/EventHandler.cpp - Issue 267313008: First-cut at fixing unhandled Tap event returns in Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventHandler.cpp

Issue 267313008: First-cut at fixing unhandled Tap event returns in Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add Layout tests, and remove unit tests. Cleanup EventHandler. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/events/touch/gesture/gesture-tap-result.html ('K') | « LayoutTests/fast/events/touch/gesture/gesture-tap-result-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/EventHandler.cpp

diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp

index 55a07108fe384eddf4e7d7407552417884a1d2ed..fcc9e4f8cc6f7e80071cffa1057b150e56639c86 100644

--- a/Source/core/page/EventHandler.cpp

+++ b/Source/core/page/EventHandler.cpp

@@ -538,8 +538,9 @@ bool EventHandler::handleMousePressEventSingleClick(const MouseEventWithHitTestR

newSelection = expandSelectionToRespectUserSelectAll(innerNode, VisibleSelection(visiblePos));

}

- bool handled = updateSelectionForMouseDownDispatchingSelectStart(innerNode, newSelection, granularity);

- return handled;

+ // Updating the selection is considered side-effect of the event and so it doesn't impact the handled state.

+ updateSelectionForMouseDownDispatchingSelectStart(innerNode, newSelection, granularity);

+ return false;

}

static inline bool canMouseDownStartSelect(Node* node)