Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: Source/core/page/EventHandler.cpp

Issue 267313008: First-cut at fixing unhandled Tap event returns in Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed handlers for all events other than mousedown. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/events/touch/gesture/gesture-tap-result-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed.
3 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 3 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
4 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies) 4 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 520 matching lines...) Expand 10 before | Expand all | Expand 10 after
531 newSelection.setExtent(pos); 531 newSelection.setExtent(pos);
532 532
533 if (m_frame->selection().granularity() != CharacterGranularity) { 533 if (m_frame->selection().granularity() != CharacterGranularity) {
534 granularity = m_frame->selection().granularity(); 534 granularity = m_frame->selection().granularity();
535 newSelection.expandUsingGranularity(m_frame->selection().granularity ()); 535 newSelection.expandUsingGranularity(m_frame->selection().granularity ());
536 } 536 }
537 } else { 537 } else {
538 newSelection = expandSelectionToRespectUserSelectAll(innerNode, VisibleS election(visiblePos)); 538 newSelection = expandSelectionToRespectUserSelectAll(innerNode, VisibleS election(visiblePos));
539 } 539 }
540 540
541 bool handled = updateSelectionForMouseDownDispatchingSelectStart(innerNode, newSelection, granularity); 541 // Updating the selection is considered side-effect of the event and so it d oesn't impact the handled state.
542 return handled; 542 updateSelectionForMouseDownDispatchingSelectStart(innerNode, newSelection, g ranularity);
543 return false;
543 } 544 }
544 545
545 static inline bool canMouseDownStartSelect(Node* node) 546 static inline bool canMouseDownStartSelect(Node* node)
546 { 547 {
547 if (!node || !node->renderer()) 548 if (!node || !node->renderer())
548 return true; 549 return true;
549 550
550 if (!node->canStartSelection()) 551 if (!node->canStartSelection())
551 return false; 552 return false;
552 553
(...skipping 3178 matching lines...) Expand 10 before | Expand all | Expand 10 after
3731 unsigned EventHandler::accessKeyModifiers() 3732 unsigned EventHandler::accessKeyModifiers()
3732 { 3733 {
3733 #if OS(MACOSX) 3734 #if OS(MACOSX)
3734 return PlatformEvent::CtrlKey | PlatformEvent::AltKey; 3735 return PlatformEvent::CtrlKey | PlatformEvent::AltKey;
3735 #else 3736 #else
3736 return PlatformEvent::AltKey; 3737 return PlatformEvent::AltKey;
3737 #endif 3738 #endif
3738 } 3739 }
3739 3740
3740 } // namespace WebCore 3741 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/events/touch/gesture/gesture-tap-result-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698