Issue 26731004: Add a test for canceling in-flight jobs in drive::JobScheduler.

Issue 26731004: Add a test for canceling in-flight jobs in drive::JobScheduler. (Closed)

Created:
7 years, 2 months ago by kinaba

Modified:
7 years, 2 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add a test for canceling in-flight jobs in drive::JobScheduler. BUG=228855 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228905

Patch Set 2 : Review fix (#2) #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -4 lines)			Patch
	M	chrome/browser/chromeos/drive/job_scheduler_unittest.cc	View	1	4 chunks	+82 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hashimoto

lgtm https://codereview.chromium.org/26731004/diff/1/chrome/browser/chromeos/drive/job_scheduler_unittest.cc File chrome/browser/chromeos/drive/job_scheduler_unittest.cc (right): https://codereview.chromium.org/26731004/diff/1/chrome/browser/chromeos/drive/job_scheduler_unittest.cc#newcode90 chrome/browser/chromeos/drive/job_scheduler_unittest.cc:90: // When set_upload_new_file_cancelable is set, this Drive service ...

7 years, 2 months ago (2013-10-16 05:50:09 UTC) #2

kinaba

https://codereview.chromium.org/26731004/diff/1/chrome/browser/chromeos/drive/job_scheduler_unittest.cc File chrome/browser/chromeos/drive/job_scheduler_unittest.cc (right): https://codereview.chromium.org/26731004/diff/1/chrome/browser/chromeos/drive/job_scheduler_unittest.cc#newcode90 chrome/browser/chromeos/drive/job_scheduler_unittest.cc:90: // When set_upload_new_file_cancelable is set, this Drive service starts ...

7 years, 2 months ago (2013-10-16 06:10:53 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/26731004/11001

7 years, 2 months ago (2013-10-16 06:11:20 UTC) #4

Message was sent while issue was closed.

Change committed as 228905

Expand Messages | Collapse Messages