Refactor type finalization in VM so that the parser only resolves type

Refactor type finalization in VM so that the parser only resolves type
parameters, whereas the class finalizer resolves all other type names and
performs finalization and canonicalization. This allows to remove a lot of
duplicated code between parser and class finalizer.

R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/f3080b8803d683d374b97b1b23a9ba42332bdc7b

[regis, 2017-02-03 18:24:10]

regis@google.com changed reviewers:
+ hausner@google.com

[hausner, 2017-02-03 20:27:02]

LGTM. Looks much cleaner now.

https://codereview.chromium.org/2673093003/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2673093003/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:12239: }
Is it no longer necessary to look up classes from qualified imported types?

[regis, 2017-02-03 20:36:43]

Thanks!

https://codereview.chromium.org/2673093003/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2673093003/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:12239: }
On 2017/02/03 20:27:01, hausner wrote:
> Is it no longer necessary to look up classes from qualified imported types?

We do it later in ClassFinalizer::ResolveClass().

[regis, 2017-02-03 20:38:39]

Description was changed from

==========
Refactor type finalization in VM so that the parser only resolves type
parameters, whereas the class finalizer resolves all other type names and
performs finalization and canonicalization. This allows to remove a lot of
duplicated code between parser and class finalizer.
==========

to

==========
Refactor type finalization in VM so that the parser only resolves type
parameters, whereas the class finalizer resolves all other type names and
performs finalization and canonicalization. This allows to remove a lot of
duplicated code between parser and class finalizer.

R=hausner@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f3080b8803d683d374b97b1b23a9ba42332bdc7b
==========

[regis, 2017-02-03 20:38:41]

Committed patchset #1 (id:1) manually as
f3080b8803d683d374b97b1b23a9ba42332bdc7b (presubmit successful).