components/password_manager/core/browser/password_manager_client.cc - Issue 2673053002: Obsolete HTTP Cleaner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_client.cc

Issue 2673053002: Obsolete HTTP Cleaner (Closed)

Patch Set: Fix Tests and remove mock of GetSiteStats Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/hsts_deleter_unittest.cc ('K') | « components/password_manager/core/browser/password_manager_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_client.cc

diff --git a/components/password_manager/core/browser/password_manager_client.cc b/components/password_manager/core/browser/password_manager_client.cc

index 2c51dc644cc947684d79666d083286d936b0d589..7d214882ce2fefd903ed2176495d847f4639863a 100644

--- a/components/password_manager/core/browser/password_manager_client.cc

+++ b/components/password_manager/core/browser/password_manager_client.cc

@@ -19,6 +19,10 @@ bool PasswordManagerClient::IsFillingEnabledForCurrentPage() const {

return true;

}

+bool PasswordManagerClient::IsHSTSActiveForOrigin(const GURL& origin) const {

+ return false;

vasilii 2017/02/06 16:43:24 What's on iOS? Separate CL?

jdoerrie 2017/02/07 13:15:06 Yep.

bool PasswordManagerClient::OnCredentialManagerUsed() {

return true;

}