| Index: components/password_manager/core/browser/hsts_deleter_unittest.cc
|
| diff --git a/components/password_manager/core/browser/hsts_deleter_unittest.cc b/components/password_manager/core/browser/hsts_deleter_unittest.cc
|
| new file mode 100644
|
| index 0000000000000000000000000000000000000000..a01db04f483d6d4046a2ad5770f5f9558683c554
|
| --- /dev/null
|
| +++ b/components/password_manager/core/browser/hsts_deleter_unittest.cc
|
| @@ -0,0 +1,193 @@
|
| +// Copyright 2017 The Chromium Authors. All rights reserved.
|
| +// Use of this source code is governed by a BSD-style license that can be
|
| +// found in the LICENSE file.
|
| +
|
| +#include "components/password_manager/core/browser/hsts_deleter.h"
|
| +
|
| +#include "base/memory/ptr_util.h"
|
| +#include "base/message_loop/message_loop.h"
|
| +#include "base/strings/utf_string_conversions.h"
|
| +#include "components/password_manager/core/browser/mock_password_store.h"
|
| +#include "components/password_manager/core/browser/stub_password_manager_client.h"
|
| +#include "testing/gmock/include/gmock/gmock.h"
|
| +#include "testing/gtest/include/gtest/gtest.h"
|
| +#include "url/gurl.h"
|
| +
|
| +using autofill::PasswordForm;
|
| +using testing::Return;
|
| +
|
| +namespace password_manager {
|
| +
|
| +namespace {
|
| +
|
| +constexpr char kTestHttpURL[] = "http://example.org/";
|
| +constexpr char kTestHttpsURL[] = "https://example.org/";
|
| +
|
| +PasswordForm CreateTestHTTPForm() {
|
| + PasswordForm form;
|
| + form.origin = GURL(kTestHttpURL);
|
| + form.signon_realm = form.origin.spec();
|
| + form.action = form.origin;
|
| + form.username_value = base::ASCIIToUTF16("user");
|
| + form.password_value = base::ASCIIToUTF16("password");
|
| + return form;
|
| +}
|
| +
|
| +PasswordForm CreateTestHTTPSForm() {
|
| + PasswordForm form;
|
| + form.origin = GURL(kTestHttpsURL);
|
| + form.signon_realm = form.origin.spec();
|
| + form.action = form.origin;
|
| + form.username_value = base::ASCIIToUTF16("user");
|
| + form.password_value = base::ASCIIToUTF16("password");
|
| + return form;
|
| +}
|
| +
|
| +InteractionsStats CreateTestHTTPStats() {
|
| + InteractionsStats stats;
|
| + stats.origin_domain = GURL(kTestHttpURL);
|
| + stats.username_value = base::ASCIIToUTF16("user");
|
| + return stats;
|
| +}
|
| +
|
| +InteractionsStats CreateTestHTTPSStats() {
|
| + InteractionsStats stats;
|
| + stats.origin_domain = GURL(kTestHttpsURL);
|
| + stats.username_value = base::ASCIIToUTF16("user");
|
| + return stats;
|
| +}
|
| +
|
| +// Small helper that wraps passed in forms in unique ptrs.
|
| +std::vector<std::unique_ptr<PasswordForm>> MakeResults(
|
| + const std::vector<PasswordForm>& forms) {
|
| + std::vector<std::unique_ptr<PasswordForm>> results;
|
| + results.reserve(forms.size());
|
| + for (const auto& form : forms)
|
| + results.push_back(base::MakeUnique<PasswordForm>(form));
|
| + return results;
|
| +}
|
| +class MockPasswordManagerClient : public StubPasswordManagerClient {
|
| + public:
|
| + MOCK_CONST_METHOD1(IsHSTSActiveForOrigin, bool(const GURL&));
|
| +};
|
| +
|
| +} // namespace
|
| +
|
| +class HstsDeleterTest : public testing::Test {
|
| + public:
|
| + HstsDeleterTest() : mock_store_(new testing::StrictMock<MockPasswordStore>) {}
|
| + ~HstsDeleterTest() override { mock_store_->ShutdownOnUIThread(); }
|
| +
|
| + MockPasswordStore& store() { return *mock_store_; }
|
| + MockPasswordManagerClient& client() { return client_; }
|
| +
|
| + private:
|
| + base::MessageLoop message_loop_; // Used by mock_store_.
|
| + scoped_refptr<MockPasswordStore> mock_store_;
|
| + MockPasswordManagerClient client_;
|
| +
|
| + DISALLOW_COPY_AND_ASSIGN(HstsDeleterTest);
|
| +};
|
| +
|
| +TEST_F(HstsDeleterTest, TestBlacklistDeletion) {
|
| + struct TestCase {
|
| + bool is_http;
|
| + bool is_blacklisted;
|
| + bool is_hsts;
|
| + bool is_deleted;
|
| + };
|
| +
|
| + constexpr static TestCase cases[] = {
|
| + {true, true, true, true}, {true, true, false, false},
|
| + {true, false, true, false}, {true, false, false, false},
|
| + {false, true, true, false}, {false, true, false, false},
|
| + {false, false, true, false}, {false, false, false, false},
|
| + };
|
| +
|
| + HstsDeleter deleter(&client(), &store());
|
| + for (const auto test_case : cases) {
|
| + PasswordForm form =
|
| + test_case.is_http ? CreateTestHTTPForm() : CreateTestHTTPSForm();
|
| + form.blacklisted_by_user = test_case.is_blacklisted;
|
| + if (test_case.is_http && test_case.is_blacklisted)
|
| + EXPECT_CALL(client(), IsHSTSActiveForOrigin(form.origin))
|
| + .WillOnce(Return(test_case.is_hsts));
|
| + EXPECT_CALL(store(), RemoveLogin(form)).Times(test_case.is_deleted);
|
| + deleter.OnGetPasswordStoreResults(MakeResults({form}));
|
| + }
|
| +}
|
| +
|
| +TEST_F(HstsDeleterTest, TestAutofillableDeletion) {
|
| + struct TestCase {
|
| + bool is_hsts;
|
| + bool same_host;
|
| + bool same_user;
|
| + bool same_pass;
|
| + bool is_deleted;
|
| + };
|
| +
|
| + constexpr static TestCase cases[] = {
|
| + {true, true, true, true, true}, {true, true, true, false, false},
|
| + {true, true, false, true, false}, {true, true, false, false, false},
|
| + {true, false, true, true, false}, {true, false, true, false, false},
|
| + {true, false, false, true, false}, {true, false, false, false, false},
|
| + {false, true, true, true, false}, {false, true, true, false, false},
|
| + {false, true, false, true, false}, {false, true, false, false, false},
|
| + {false, false, true, true, false}, {false, false, true, false, false},
|
| + {false, false, false, true, false}, {false, false, false, false, false},
|
| + };
|
| +
|
| + HstsDeleter deleter(&client(), &store());
|
| + for (const auto test_case : cases) {
|
| + PasswordForm http_form = CreateTestHTTPForm();
|
| + PasswordForm https_form = CreateTestHTTPSForm();
|
| +
|
| + if (!test_case.same_host) {
|
| + GURL::Replacements rep;
|
| + rep.SetHostStr(https_form.origin.host() + "-different");
|
| + http_form.origin = http_form.origin.ReplaceComponents(rep);
|
| + }
|
| +
|
| + if (!test_case.same_user)
|
| + http_form.username_value =
|
| + https_form.username_value + base::ASCIIToUTF16("-different");
|
| +
|
| + if (!test_case.same_pass)
|
| + http_form.password_value =
|
| + https_form.password_value + base::ASCIIToUTF16("-different");
|
| +
|
| + EXPECT_CALL(client(), IsHSTSActiveForOrigin(https_form.origin))
|
| + .WillOnce(Return(test_case.is_hsts));
|
| + EXPECT_CALL(store(), RemoveLogin(http_form)).Times(test_case.is_deleted);
|
| + deleter.OnGetPasswordStoreResults(MakeResults({http_form, https_form}));
|
| + }
|
| +}
|
| +
|
| +TEST_F(HstsDeleterTest, TestSiteStatsDeletion) {
|
| + struct TestCase {
|
| + bool is_http;
|
| + bool is_hsts;
|
| + bool is_deleted;
|
| + };
|
| +
|
| + constexpr static TestCase cases[] = {
|
| + {true, true, true},
|
| + {true, false, false},
|
| + {false, true, false},
|
| + {false, false, false},
|
| + };
|
| +
|
| + HstsDeleter deleter(&client(), &store());
|
| + for (const auto test_case : cases) {
|
| + InteractionsStats stats =
|
| + test_case.is_http ? CreateTestHTTPStats() : CreateTestHTTPSStats();
|
| + if (test_case.is_http)
|
| + EXPECT_CALL(client(), IsHSTSActiveForOrigin(stats.origin_domain))
|
| + .WillOnce(Return(test_case.is_hsts));
|
| + EXPECT_CALL(store(), RemoveSiteStats(stats.origin_domain))
|
| + .Times(test_case.is_deleted);
|
| + deleter.OnGetSiteStatistics({stats});
|
| + }
|
| +}
|
| +
|
| +} // namespace password_manager
|
|
|