Obsolete HTTP Cleaner

components/password_manager/core/browser/hsts_deleter.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_HSTS_DELETER_H_
+#define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_HSTS_DELETER_H_
+
+#include <memory>
+#include <vector>
+
+#include "base/macros.h"
+#include "components/password_manager/core/browser/password_store_consumer.h"
+
+namespace autofill {
+struct PasswordForm;
+}
+
+namespace password_manager {
+
+struct InteractionsStats;
+class PasswordManagerClient;
+class PasswordStore;
+
+class HstsDeleter : public PasswordStoreConsumer {

[vasilii, 2017/02/06 16:43:24]

A comment? The name isn't clear at all. The class definitely doesn't clear HSTS.

So far the lifetime of the object is unclear to me. It can be a follow-up CL.

[jdoerrie, 2017/02/07 13:15:02]

Done.

+ public:
+  HstsDeleter(const PasswordManagerClient* client,
+              PasswordStore* password_store);

[vasilii, 2017/02/06 16:43:24]

You can get the password store from the client with GetPasswordStore()

[jdoerrie, 2017/02/07 13:15:01]

Done.

+

[vasilii, 2017/02/06 16:43:24]

A virtual destructor?

[jdoerrie, 2017/02/07 13:15:00]

Done.

+  // PasswordStoreConsumer:
+  // This will be called for both autofillable logins as well as blacklisted
+  // logins. Blacklisted logins are removed iff the scheme is HTTP and HSTS is
+  // enabled for the host.
+  // Autofillable logins are removed iff the scheme is HTTP and there exists
+  // another HTTPS login with active HSTS that has the same host as well as the
+  // same username and password.
+  void OnGetPasswordStoreResults(
+      std::vector<std::unique_ptr<autofill::PasswordForm>> results) override;
+
+  // This will remove all stats for HTTP sites for which HSTS is active.
+  void OnGetSiteStatistics(std::vector<InteractionsStats> stats) override;
+
+ private:
+  const PasswordManagerClient* const client_;
+  PasswordStore* password_store_;
+
+  DISALLOW_COPY_AND_ASSIGN(HstsDeleter);
+};
+
+}  // namespace password_manager
+
+#endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_HSTS_DELETER_H_