Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1606)

Unified Diff: Source/core/svg/SVGElementInstance.h

Issue 267303004: Oilpan: cleanup based on review comments after removal of TreeShared. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix typo and merge Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGElement.cpp ('k') | Source/core/svg/SVGElementInstance.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGElementInstance.h
diff --git a/Source/core/svg/SVGElementInstance.h b/Source/core/svg/SVGElementInstance.h
index 135632943f05354e9e1eed2fd77443cf5f24e5ec..83667547a0ddd99f4a7492bd9adf06d713221ded 100644
--- a/Source/core/svg/SVGElementInstance.h
+++ b/Source/core/svg/SVGElementInstance.h
@@ -126,7 +126,11 @@ private:
SVGElementInstance(SVGUseElement*, SVGUseElement*, PassRefPtr<SVGElement> originalElement);
+
+#if !ENABLE(OILPAN)
void removedLastRef();
+#endif
+
bool hasTreeSharedParent() const { return !!m_parentInstance; }
virtual Node* toNode() OVERRIDE;
@@ -137,11 +141,13 @@ private:
template<class GenericNode, class GenericNodeContainer>
friend void appendChildToContainer(GenericNode& child, GenericNodeContainer&);
+#if !ENABLE(OILPAN)
template<class GenericNode, class GenericNodeContainer>
friend void removeDetachedChildrenInContainer(GenericNodeContainer&);
template<class GenericNode, class GenericNodeContainer>
friend void Private::addChildNodesToDeletionQueue(GenericNode*& head, GenericNode*& tail, GenericNodeContainer&);
+#endif
bool hasChildren() const { return m_firstChild; }
@@ -156,8 +162,8 @@ private:
RawPtrWillBeMember<SVGElementInstance> m_parentInstance;
- SVGUseElement* m_correspondingUseElement;
- SVGUseElement* m_directUseElement;
+ RawPtrWillBeMember<SVGUseElement> m_correspondingUseElement;
+ RawPtrWillBeMember<SVGUseElement> m_directUseElement;
RefPtrWillBeMember<SVGElement> m_element;
RefPtrWillBeMember<SVGElement> m_shadowTreeElement;
« no previous file with comments | « Source/core/svg/SVGElement.cpp ('k') | Source/core/svg/SVGElementInstance.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698