Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: Source/core/html/HTMLFormControlElement.cpp

Issue 267303004: Oilpan: cleanup based on review comments after removal of TreeShared. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLFormControlElement.cpp
diff --git a/Source/core/html/HTMLFormControlElement.cpp b/Source/core/html/HTMLFormControlElement.cpp
index 9bc9d1d066208c6f0da2f899a2b25720ddcf877d..484162b1199099c17414985d738e79702e43d62f 100644
--- a/Source/core/html/HTMLFormControlElement.cpp
+++ b/Source/core/html/HTMLFormControlElement.cpp
@@ -65,7 +65,6 @@ HTMLFormControlElement::~HTMLFormControlElement()
{
#if !ENABLE(OILPAN)
setForm(0);
- hideVisibleValidationMessage();
haraken 2014/05/07 12:50:20 tkent-san: I'm not sure if we can remove this. See
Mads Ager (chromium) 2014/05/08 09:08:59 Kent confirmed that this can be removed on the oth
#endif
}
@@ -423,8 +422,8 @@ bool HTMLFormControlElement::checkValidity(Vector<RefPtr<FormAssociatedElement>
if (!willValidate() || isValidFormControlElement())
return true;
// An event handler can deref this object.
- RefPtr<HTMLFormControlElement> protector(this);
- RefPtr<Document> originalDocument(document());
+ RefPtrWillBeRawPtr<HTMLFormControlElement> protector(this);
+ RefPtrWillBeRawPtr<Document> originalDocument(document());
bool needsDefaultAction = dispatchEvent(Event::createCancelable(EventTypeNames::invalid));
if (needsDefaultAction && unhandledInvalidControls && inDocument() && originalDocument == document())
unhandledInvalidControls->append(this);

Powered by Google App Engine
This is Rietveld 408576698