Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: Source/core/svg/properties/SVGAnimatedProperty.cpp

Issue 267303004: Oilpan: cleanup based on review comments after removal of TreeShared. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix typo and merge Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGUseElement.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 { 44 {
45 ASSERT(m_contextElement); 45 ASSERT(m_contextElement);
46 ASSERT(m_attributeName != nullQName()); 46 ASSERT(m_attributeName != nullQName());
47 // FIXME: setContextElement should be delayed until V8 wrapper is created. 47 // FIXME: setContextElement should be delayed until V8 wrapper is created.
48 // FIXME: oilpan: or we can remove this backref ptr hack in oilpan. 48 // FIXME: oilpan: or we can remove this backref ptr hack in oilpan.
49 m_contextElement->setContextElement(); 49 m_contextElement->setContextElement();
50 } 50 }
51 51
52 SVGAnimatedPropertyBase::~SVGAnimatedPropertyBase() 52 SVGAnimatedPropertyBase::~SVGAnimatedPropertyBase()
53 { 53 {
54 // FIXME: Oilpan: We need to investigate why this assert fails in
55 // Oilpan builds.
54 #if !ENABLE(OILPAN) 56 #if !ENABLE(OILPAN)
55 ASSERT(!isAnimating()); 57 ASSERT(!isAnimating());
56 #endif 58 #endif
57 } 59 }
58 60
59 void SVGAnimatedPropertyBase::animationStarted() 61 void SVGAnimatedPropertyBase::animationStarted()
60 { 62 {
61 ASSERT(!isAnimating()); 63 ASSERT(!isAnimating());
62 m_isAnimating = true; 64 m_isAnimating = true;
63 } 65 }
(...skipping 11 matching lines...) Expand all
75 AtomicString value(currentValueBase()->valueAsString()); 77 AtomicString value(currentValueBase()->valueAsString());
76 m_contextElement->setSynchronizedLazyAttribute(m_attributeName, value); 78 m_contextElement->setSynchronizedLazyAttribute(m_attributeName, value);
77 } 79 }
78 80
79 bool SVGAnimatedPropertyBase::isSpecified() const 81 bool SVGAnimatedPropertyBase::isSpecified() const
80 { 82 {
81 return isAnimating() || contextElement()->hasAttribute(attributeName()); 83 return isAnimating() || contextElement()->hasAttribute(attributeName());
82 } 84 }
83 85
84 } // namespace WebCore 86 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/svg/SVGUseElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698