Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Side by Side Diff: Source/core/rendering/RenderListBox.cpp

Issue 267303004: Oilpan: cleanup based on review comments after removal of TreeShared. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
3 * 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 3 * 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 939 matching lines...) Expand 10 before | Expand all | Expand 10 after
950 950
951 if (!m_vBar->isCustomScrollbar()) 951 if (!m_vBar->isCustomScrollbar())
952 ScrollableArea::willRemoveScrollbar(m_vBar.get(), VerticalScrollbar); 952 ScrollableArea::willRemoveScrollbar(m_vBar.get(), VerticalScrollbar);
953 m_vBar->removeFromParent(); 953 m_vBar->removeFromParent();
954 m_vBar->disconnectFromScrollableArea(); 954 m_vBar->disconnectFromScrollableArea();
955 m_vBar = nullptr; 955 m_vBar = nullptr;
956 } 956 }
957 957
958 void RenderListBox::setHasVerticalScrollbar(bool hasScrollbar) 958 void RenderListBox::setHasVerticalScrollbar(bool hasScrollbar)
959 { 959 {
960 if (hasScrollbar == (m_vBar != 0)) 960 if (hasScrollbar == !!m_vBar)
961 return; 961 return;
962 962
963 if (hasScrollbar) 963 if (hasScrollbar)
964 m_vBar = createScrollbar(); 964 m_vBar = createScrollbar();
965 else 965 else
966 destroyScrollbar(); 966 destroyScrollbar();
967 967
968 if (m_vBar) 968 if (m_vBar)
969 m_vBar->styleChanged(); 969 m_vBar->styleChanged();
970 970
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
1022 { 1022 {
1023 return itemBoundingBoxRectInternal(point, listIndexToRenderListBoxIndex(inde x)); 1023 return itemBoundingBoxRectInternal(point, listIndexToRenderListBoxIndex(inde x));
1024 } 1024 }
1025 1025
1026 bool RenderListBox::scrollToRevealElementAtListIndex(int index) 1026 bool RenderListBox::scrollToRevealElementAtListIndex(int index)
1027 { 1027 {
1028 return scrollToRevealElementAtListIndexInternal(listIndexToRenderListBoxInde x(index)); 1028 return scrollToRevealElementAtListIndexInternal(listIndexToRenderListBoxInde x(index));
1029 } 1029 }
1030 1030
1031 } // namespace WebCore 1031 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698