Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm

Issue 2673003002: [Reading List] Display the redirected URL's favicon. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm
diff --git a/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm b/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm
index ff9f45e8bd929dcdaff45f793a8497e052f6c040..a8a394d9081fd2ec83e8293685567ea86d7c49d6 100644
--- a/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm
+++ b/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm
@@ -589,6 +589,7 @@ using ItemsMapByDate = std::multimap<int64_t, ReadingListCollectionViewItem*>;
if (oldItem.url == newItem.url) {
oldItem.text = newItem.text;
oldItem.distillationState = newItem.distillationState;
+ oldItem.faviconPageURL = newItem.faviconPageURL;
}
if (![oldItem isEqual:newItem]) {
return YES;
@@ -609,6 +610,8 @@ using ItemsMapByDate = std::multimap<int64_t, ReadingListCollectionViewItem*>;
base::string16 urlString = url_formatter::FormatUrl(url);
item.text = base::SysUTF8ToNSString(entry.Title());
item.detailText = base::SysUTF16ToNSString(urlString);
+ item.faviconPageURL =
+ entry.DistilledURL().is_valid() ? entry.DistilledURL() : url;
return item;
}

Powered by Google App Engine
This is Rietveld 408576698