Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js

Issue 2672983002: [DevTools] Separate ScreenCaptureModel out of ResourceTreeModel. (Closed)
Patch Set: rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
index 327dac9e50f6667ee06e1ec6959391abc2656eee..bf980891a8fb9d32d6c65f6c5da397b9787652ed 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
@@ -463,8 +463,6 @@ SDK.ResourceTreeModel.Events = {
Load: Symbol('Load'),
PageReloadRequested: Symbol('PageReloadRequested'),
WillReloadPage: Symbol('WillReloadPage'),
- ScreencastFrame: Symbol('ScreencastFrame'),
- ScreencastVisibilityChanged: Symbol('ScreencastVisibilityChanged'),
ColorPicked: Symbol('ColorPicked'),
InterstitialShown: Symbol('InterstitialShown'),
InterstitialHidden: Symbol('InterstitialHidden')
@@ -746,6 +744,9 @@ SDK.ResourceTreeFrame = class {
* @unrestricted
*/
SDK.PageDispatcher = class {
+ /**
+ * @param {!SDK.ResourceTreeModel} resourceTreeModel
+ */
constructor(resourceTreeModel) {
this._resourceTreeModel = resourceTreeModel;
}
@@ -846,13 +847,10 @@ SDK.PageDispatcher = class {
/**
* @override
* @param {string} data
- * @param {!Protocol.Page.ScreencastFrameMetadata=} metadata
- * @param {number=} sessionId
+ * @param {!Protocol.Page.ScreencastFrameMetadata} metadata
+ * @param {number} sessionId
*/
screencastFrame(data, metadata, sessionId) {
- this._resourceTreeModel._agent.screencastFrameAck(sessionId);
- this._resourceTreeModel.dispatchEventToListeners(
- SDK.ResourceTreeModel.Events.ScreencastFrame, {data: data, metadata: metadata});
}
/**
@@ -860,8 +858,6 @@ SDK.PageDispatcher = class {
* @param {boolean} visible
*/
screencastVisibilityChanged(visible) {
- this._resourceTreeModel.dispatchEventToListeners(
- SDK.ResourceTreeModel.Events.ScreencastVisibilityChanged, {visible: visible});
}
/**

Powered by Google App Engine
This is Rietveld 408576698