Replace computeNode() with AstProvider in search.

Replace computeNode() with AstProvider in search.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/7d2447d795c57d6e81a9dc036a5ac65f0fca3e83

[Brian Wilkerson, 2017-02-03 14:43:47]

lgtm

https://codereview.chromium.org/2672973002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/search/search_engine_internal.dart
(right):

https://codereview.chromium.org/2672973002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/search/search_engine_internal.dart:28:
typedef AstProvider GetAstProvider(String file);
Is this necessary? It seems like it's just as performant to create the
AstProvider as it is to create the closure to return the AstProvider, and less
indirection through functions would be better.

[scheglov, 2017-02-03 18:31:36]

https://codereview.chromium.org/2672973002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/search/search_engine_internal.dart
(right):

https://codereview.chromium.org/2672973002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/search/search_engine_internal.dart:28:
typedef AstProvider GetAstProvider(String file);
On 2017/02/03 14:43:47, Brian Wilkerson wrote:
> Is this necessary? It seems like it's just as performant to create the
> AstProvider as it is to create the closure to return the AstProvider, and less
> indirection through functions would be better.

AstProvider is bound to a single AnalysisDriver or AnalysisContext.

When we create SearchEngineImpl, we don't know which local Element(s) will be
searched. Depending on the specific element, we need to choose AnalysisDriver,
and so AstProvider.

[Brian Wilkerson, 2017-02-03 18:38:26]

https://codereview.chromium.org/2672973002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/search/search_engine_internal.dart
(right):

https://codereview.chromium.org/2672973002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/search/search_engine_internal.dart:28:
typedef AstProvider GetAstProvider(String file);
> AstProvider is bound to a single AnalysisDriver or AnalysisContext.
> 
> When we create SearchEngineImpl, we don't know which local Element(s) will be
> searched. Depending on the specific element, we need to choose AnalysisDriver,
> and so AstProvider.

That makes sense. It would be good to add that to a comment so it's clear later.

[scheglov, 2017-02-03 18:40:47]

Description was changed from

==========
Replace computeNode() with AstProvider in search.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Replace computeNode() with AstProvider in search.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/7d2447d795c57d6e81a9dc036a5ac65f0fca3e83
==========

[scheglov, 2017-02-03 18:40:48]

Committed patchset #1 (id:1) manually as
7d2447d795c57d6e81a9dc036a5ac65f0fca3e83 (presubmit successful).