Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: ios/web/navigation/crw_session_entry_unittest.mm

Issue 2672953005: Updated ownership of NavigationItems within CRWSessionController. (Closed)
Patch Set: self review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/navigation/crw_session_entry_unittest.mm
diff --git a/ios/web/navigation/crw_session_entry_unittest.mm b/ios/web/navigation/crw_session_entry_unittest.mm
index aae10d0d65f376f7e3bab5fb9d5fffa01adb08f2..2fe6708fb3e79306dcb7d87b16bdf17b54194379 100644
--- a/ios/web/navigation/crw_session_entry_unittest.mm
+++ b/ios/web/navigation/crw_session_entry_unittest.mm
@@ -33,18 +33,18 @@ void SetUp() override {
GURL url("http://init.test");
ui::PageTransition transition =
ui::PAGE_TRANSITION_AUTO_BOOKMARK;
- std::unique_ptr<web::NavigationItemImpl> item(
- new web::NavigationItemImpl());
- item->SetOriginalRequestURL(url);
- item->SetURL(url);
- item->SetTransitionType(transition);
- item->SetTimestamp(base::Time::Now());
- item->SetPostData([@"Test data" dataUsingEncoding:NSUTF8StringEncoding]);
+ _item.reset(new web::NavigationItemImpl());
+ _item->SetOriginalRequestURL(url);
+ _item->SetURL(url);
+ _item->SetTransitionType(transition);
+ _item->SetTimestamp(base::Time::Now());
+ _item->SetPostData([@"Test data" dataUsingEncoding:NSUTF8StringEncoding]);
_sessionEntry.reset(
- [[CRWSessionEntry alloc] initWithNavigationItem:std::move(item)]);
+ [[CRWSessionEntry alloc] initWithNavigationItem:_item.get()]);
}
protected:
+ std::unique_ptr<web::NavigationItemImpl> _item;
base::scoped_nsobject<CRWSessionEntry> _sessionEntry;
};

Powered by Google App Engine
This is Rietveld 408576698