Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: ios/web/navigation/crw_session_controller_unittest.mm

Issue 2672953005: Updated ownership of NavigationItems within CRWSessionController. (Closed)
Patch Set: self review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/navigation/crw_session_controller_unittest.mm
diff --git a/ios/web/navigation/crw_session_controller_unittest.mm b/ios/web/navigation/crw_session_controller_unittest.mm
index 40b2c18c8896dd6b4ff8b8883cc8c9aef5561da5..cc4f3c8bd0fc32e95e8f0ab0ce2c962f2401ed6c 100644
--- a/ios/web/navigation/crw_session_controller_unittest.mm
+++ b/ios/web/navigation/crw_session_controller_unittest.mm
@@ -808,18 +808,12 @@ void SetUp() override {
[[CRWSessionController alloc] initWithNavigationItems:std::move(items)
currentIndex:0
browserState:&browser_state_]);
- web::NavigationItemImpl* item0 =
- static_cast<web::NavigationItemImpl*>([controller items][0]);
- web::NavigationItemImpl* item1 =
- static_cast<web::NavigationItemImpl*>([controller items][1]);
- web::NavigationItemImpl* item2 =
- static_cast<web::NavigationItemImpl*>([controller items][2]);
- web::NavigationItemImpl* item3 =
- static_cast<web::NavigationItemImpl*>([controller items][3]);
- web::NavigationItemImpl* item4 =
- static_cast<web::NavigationItemImpl*>([controller items][4]);
- web::NavigationItemImpl* item5 =
- static_cast<web::NavigationItemImpl*>([controller items][5]);
+ web::NavigationItemImpl* item0 = [controller items][0].get();
+ web::NavigationItemImpl* item1 = [controller items][1].get();
+ web::NavigationItemImpl* item2 = [controller items][2].get();
+ web::NavigationItemImpl* item3 = [controller items][3].get();
+ web::NavigationItemImpl* item4 = [controller items][4].get();
+ web::NavigationItemImpl* item5 = [controller items][5].get();
item1->SetIsCreatedFromPushState(true);
item4->SetIsCreatedFromHashChange(true);
item5->SetIsCreatedFromPushState(true);

Powered by Google App Engine
This is Rietveld 408576698