ios/web/web_state/ui/crw_web_controller_unittest.mm - Issue 2672953005: Updated ownership of NavigationItems within CRWSessionController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller_unittest.mm

Issue 2672953005: Updated ownership of NavigationItems within CRWSessionController. (Closed)

Patch Set: fix unittests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_web_controller_unittest.mm

diff --git a/ios/web/web_state/ui/crw_web_controller_unittest.mm b/ios/web/web_state/ui/crw_web_controller_unittest.mm

index 02623a576c4913bba812d51106a54738f0752fda..75bc2921a3d8fd65bec80971d54fe7a07d5148f8 100644

--- a/ios/web/web_state/ui/crw_web_controller_unittest.mm

+++ b/ios/web/web_state/ui/crw_web_controller_unittest.mm

@@ -674,19 +674,19 @@ void TearDown() override {

typedef web::WebTestWithWebController CRWWebControllerNavigationTest;

// Tests navigation between 2 URLs which differ only by fragment.

-TEST_F(CRWWebControllerNavigationTest, GoToEntryWithoutDocumentChange) {

+TEST_F(CRWWebControllerNavigationTest, GoToItemWithoutDocumentChange) {

LoadHtml(@"<html><body></body></html>", GURL("https://chromium.test"));

LoadHtml(@"<html><body></body></html>", GURL("https://chromium.test#hash"));

NavigationManagerImpl& nav_manager =

web_controller().webStateImpl->GetNavigationManagerImpl();

CRWSessionController* session_controller = nav_manager.GetSessionController();

- EXPECT_EQ(2U, session_controller.entries.count);

- EXPECT_NSEQ(session_controller.entries.lastObject,

- session_controller.currentEntry);

+ EXPECT_EQ(2U, session_controller.items.size());

+ EXPECT_EQ(session_controller.items.back().get(),

+ session_controller.currentItem);

[web_controller() goToItemAtIndex:0];

- EXPECT_NSEQ(session_controller.entries.firstObject,

- session_controller.currentEntry);

+ EXPECT_EQ(session_controller.items.front().get(),

+ session_controller.currentItem);

}

// Tests that didShowPasswordInputOnHTTP updates the SSLStatus to indicate that

« no previous file with comments | « ios/web/public/navigation_item_list.mm ('k') | no next file » | no next file with comments »